All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Kevin Hilman <khilman@kernel.org>,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	riku.voipio@linaro.org, linux-samsung-soc@vger.kernel.org,
	tyler.baker@linaro.org
Subject: Re: [PATCH] ARM: multi_v7_defconfig: enable usb3503
Date: Fri, 05 Jun 2015 14:45:51 +0200	[thread overview]
Message-ID: <4414616.t6CSY5FxHU@wuerfel> (raw)
In-Reply-To: <7hd21b2wo4.fsf@deeprootsystems.com>

On Thursday 04 June 2015 10:47:07 Kevin Hilman wrote:
> 
> > But I wonder why is not working, shouldn't the driver defer and
> > be probed again once the PHY driver probe succeeds?
> 
> Yeah, I'm not sure why that isn't working, and didn't look into it.
> 
> FWIW, the same problem happens when both are modules.  If you modprobe
> usb3503 first, then the phy, it doesn't work.  You have to load the phy
> before the usb3503.
> 
> 

The driver does not try to get a reference to the phy, and it does
not return -EPROBE_DEFER in any circumstance, so I assume it just
runs into an error condition on the first probe and does not
try again.

I don't really understand why the driver registers both an i2c_driver
and a platform_driver, or if that is required, but it may also
complicate getting deferred probing to work here.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: multi_v7_defconfig: enable usb3503
Date: Fri, 05 Jun 2015 14:45:51 +0200	[thread overview]
Message-ID: <4414616.t6CSY5FxHU@wuerfel> (raw)
In-Reply-To: <7hd21b2wo4.fsf@deeprootsystems.com>

On Thursday 04 June 2015 10:47:07 Kevin Hilman wrote:
> 
> > But I wonder why is not working, shouldn't the driver defer and
> > be probed again once the PHY driver probe succeeds?
> 
> Yeah, I'm not sure why that isn't working, and didn't look into it.
> 
> FWIW, the same problem happens when both are modules.  If you modprobe
> usb3503 first, then the phy, it doesn't work.  You have to load the phy
> before the usb3503.
> 
> 

The driver does not try to get a reference to the phy, and it does
not return -EPROBE_DEFER in any circumstance, so I assume it just
runs into an error condition on the first probe and does not
try again.

I don't really understand why the driver registers both an i2c_driver
and a platform_driver, or if that is required, but it may also
complicate getting deferred probing to work here.

	Arnd

  reply	other threads:[~2015-06-05 12:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 13:54 [PATCH] ARM: multi_v7_defconfig: enable usb3503 riku.voipio
2015-03-13 13:54 ` riku.voipio at linaro.org
2015-06-04  1:08 ` Kevin Hilman
2015-06-04  1:08   ` Kevin Hilman
2015-06-04  6:38   ` Javier Martinez Canillas
2015-06-04  6:38     ` Javier Martinez Canillas
2015-06-04 17:47     ` Kevin Hilman
2015-06-04 17:47       ` Kevin Hilman
2015-06-05 12:45       ` Arnd Bergmann [this message]
2015-06-05 12:45         ` Arnd Bergmann
2015-09-14  8:35         ` Riku Voipio
2015-09-14  8:35           ` Riku Voipio
2015-09-15  6:50           ` Krzysztof Kozlowski
2015-09-15  6:50             ` Krzysztof Kozlowski
2015-09-15  8:17             ` Sjoerd Simons
2015-09-15  8:17               ` Sjoerd Simons
2015-09-15  8:34               ` Krzysztof Kozlowski
2015-09-15  8:34                 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4414616.t6CSY5FxHU@wuerfel \
    --to=arnd@arndb.de \
    --cc=javier.martinez@collabora.co.uk \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=riku.voipio@linaro.org \
    --cc=tyler.baker@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.