[KJ] Re: [PATCH] usb.h: reduce syslog clutter

[Tilman Schmidt <tilman@imap.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1400 bytes --]

On 20.03.2006 20:41, Greg KH wrote:

> On Sat, Mar 18, 2006 at 08:53:26PM +0100, Tilman Schmidt wrote:
> 
>>The current versions of the err() / info() / warn() message macros in
>>include/linux/usb.h insert __FILE__ at the beginning of the message.
>>[...]
>>The following patch modifies these macros so that, when used in a
>>module, they'll insert the module name instead, which is significantly
>>shorter and also tends to be more useful to users (as opposed to kernel
>>developers) trying to make sense of a particular message.
>>
>>It also adds a macro for the "notice" message level which was missing
>>so far.
>[...]
> What was wrong with my suggestion that we simply delete these macros and
> convert the USB code over to using the proper dev_info(), dev_warn(),
> dev_err(), and dev_notice() macros instead?

Just that, as you remarked yourself:

> [T]here are a few places in the USB code that do
> not have a valid device and so they can't be dropped entirely.

and I still don't see how to handle that situation with the dev_ macros.

But I thought you said you would accept that patch if I submitted it
through the kernel-janitors. Why the change of mind?

-- 
Tilman Schmidt                          E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 253 bytes --]

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors