* [PATCH] Au1xx0: OHCI region size off-by-one
@ 2006-03-20 23:38 Sergei Shtylylov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylylov @ 2006-03-20 23:38 UTC (permalink / raw)
To: Linux-MIPS; +Cc: Manish Lachwani, Jordan Crouse
[-- Attachment #1: Type: text/plain, Size: 121 bytes --]
Hello Manish.
Au1xx0 OHCI driver claims one byte too many for the memory mapped
controller registers.
WBR, Sergei
[-- Attachment #2: Au1xx0-OHCI-region-size-off-by-one.patch --]
[-- Type: text/plain, Size: 441 bytes --]
diff --git a/arch/mips/au1000/common/platform.c b/arch/mips/au1000/common/platform.c
index d7a8f0a..79407ab 100644
--- a/arch/mips/au1000/common/platform.c
+++ b/arch/mips/au1000/common/platform.c
@@ -20,7 +20,7 @@
static struct resource au1xxx_usb_ohci_resources[] = {
[0] = {
.start = USB_OHCI_BASE,
- .end = USB_OHCI_BASE + USB_OHCI_LEN,
+ .end = USB_OHCI_BASE + USB_OHCI_LEN - 1,
.flags = IORESOURCE_MEM,
},
[1] = {
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] Au1xx0: OHCI region size off-by-one
@ 2006-03-21 0:54 Sergei Shtylylov
2006-03-21 1:02 ` Martin Michlmayr
2006-05-25 18:47 ` Sergei Shtylyov
0 siblings, 2 replies; 6+ messages in thread
From: Sergei Shtylylov @ 2006-03-21 0:54 UTC (permalink / raw)
To: Linux-MIPS
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
Hello.
Reposting with signoff which I constantly forget about... :-/
Au1xx0 OHCI driver claims one byte too many for the memory mapped
controller registers.
WBR, Sergei
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
[-- Attachment #2: Au1xx0-OHCI-region-size-off-by-one.patch --]
[-- Type: text/plain, Size: 442 bytes --]
diff --git a/arch/mips/au1000/common/platform.c b/arch/mips/au1000/common/platform.c
index d7a8f0a..79407ab 100644
--- a/arch/mips/au1000/common/platform.c
+++ b/arch/mips/au1000/common/platform.c
@@ -20,7 +20,7 @@
static struct resource au1xxx_usb_ohci_resources[] = {
[0] = {
.start = USB_OHCI_BASE,
- .end = USB_OHCI_BASE + USB_OHCI_LEN,
+ .end = USB_OHCI_BASE + USB_OHCI_LEN - 1,
.flags = IORESOURCE_MEM,
},
[1] = {
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Au1xx0: OHCI region size off-by-one
2006-03-21 0:54 Sergei Shtylylov
@ 2006-03-21 1:02 ` Martin Michlmayr
2006-03-21 1:05 ` Sergei Shtylylov
2006-05-25 18:47 ` Sergei Shtylyov
1 sibling, 1 reply; 6+ messages in thread
From: Martin Michlmayr @ 2006-03-21 1:02 UTC (permalink / raw)
To: Sergei Shtylylov; +Cc: Linux-MIPS
* Sergei Shtylylov <sshtylyov@ru.mvista.com> [2006-03-21 03:54]:
> Reposting with signoff which I constantly forget about... :-/
... and please post your patches inline rather than as MIME
attachments. :)
--
Martin Michlmayr
http://www.cyrius.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Au1xx0: OHCI region size off-by-one
2006-03-21 1:02 ` Martin Michlmayr
@ 2006-03-21 1:05 ` Sergei Shtylylov
2006-03-22 12:01 ` Ralf Baechle
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylylov @ 2006-03-21 1:05 UTC (permalink / raw)
To: Martin Michlmayr; +Cc: Linux-MIPS
Martin Michlmayr wrote:
> * Sergei Shtylylov <sshtylyov@ru.mvista.com> [2006-03-21 03:54]:
>
>>Reposting with signoff which I constantly forget about... :-/
>
>
> ... and please post your patches inline rather than as MIME
> attachments. :)
My mailer will stuff tabs with spaces then, and I know text/plain
attachments are considered OK.
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Au1xx0: OHCI region size off-by-one
2006-03-21 1:05 ` Sergei Shtylylov
@ 2006-03-22 12:01 ` Ralf Baechle
0 siblings, 0 replies; 6+ messages in thread
From: Ralf Baechle @ 2006-03-22 12:01 UTC (permalink / raw)
To: Sergei Shtylylov; +Cc: Martin Michlmayr, Linux-MIPS
On Tue, Mar 21, 2006 at 04:05:11AM +0300, Sergei Shtylylov wrote:
> >... and please post your patches inline rather than as MIME
> >attachments. :)
>
> My mailer will stuff tabs with spaces then, and I know text/plain
> attachments are considered OK.
Well, the topic isn't new but here is some wisdom from others on how to
post patches with the various wannabe mail clients like Mozilla.
Quoting from Alan Cox:
> For Evolution
>
> Set the formatting to "Preformat"
> Hit Insert/Text File (Alt-I X)
> Then at the ghastly gnome dialog hit ^L (secret handshake for the
> 'developers cant stand it either' shortcut box) and type in the file
> name
And here some wisedom from Randy Dunlap on Thunderbird:
>> Randy D. eventually agreed that there was a way, IIRC:
>>
>> http://lkml.org/lkml/2005/12/27/191
>>
>> Probably can work your way through the thread to figure out how (I use mutt :)
> Yep, the odd part is not to disable html email.
> Then when composing a message, there is a drop-down box for a format
> selection. While the cursor is in the body area, change the format
> from default "Body text" to Preformat, and then copy-n-paste the patch.
> At least that's what worked for me.
And Frank Sorenson:
> Here is one method for posting patches in Thunderbird:
>
> Before starting to write the email, do Edit->Preferences, Composition
> tab, change "Wrap plain text messages at __ characters" to 0
>
> Begin writing your email
>
> Start up an editor in which you can select the text, for example:
> # gvim patch.diff
> Edit->Select All
> Edit->Copy
>
> Switch back to the open Compose window, then Edit->Paste
>
> If you have Enigmail configured, when sending the email, you might get a
> box asking if you want to change the line wrapping to 68 characters, so
> just say No if that happens.
Others have suggested using an external editor which will show up in the
compose editor and allow to include the patch file inline.
Here's Martin Bligh's page on the topic:
http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
Credits for anybody would writes some useful docs for the linux-mips wiki
on this topic - unfortunately it's really high in demand. I'd do it
myself - but I am a mutt + vi user :-)
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Au1xx0: OHCI region size off-by-one
2006-03-21 0:54 Sergei Shtylylov
2006-03-21 1:02 ` Martin Michlmayr
@ 2006-05-25 18:47 ` Sergei Shtylyov
1 sibling, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2006-05-25 18:47 UTC (permalink / raw)
To: Linux-MIPS; +Cc: Ralf Baechle, Jordan Crouse
Hello, I wrote:
> Au1xx0 OHCI driver claims one byte too many for the memory mapped
> controller registers.
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> ------------------------------------------------------------------------
>
> diff --git a/arch/mips/au1000/common/platform.c b/arch/mips/au1000/common/platform.c
> index d7a8f0a..79407ab 100644
> --- a/arch/mips/au1000/common/platform.c
> +++ b/arch/mips/au1000/common/platform.c
> @@ -20,7 +20,7 @@
> static struct resource au1xxx_usb_ohci_resources[] = {
> [0] = {
> .start = USB_OHCI_BASE,
> - .end = USB_OHCI_BASE + USB_OHCI_LEN,
> + .end = USB_OHCI_BASE + USB_OHCI_LEN - 1,
> .flags = IORESOURCE_MEM,
> },
> [1] = {
There's no need to apply this anymore -- was covered by Au1200 OCHI patch...
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-05-25 18:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-20 23:38 [PATCH] Au1xx0: OHCI region size off-by-one Sergei Shtylylov
-- strict thread matches above, loose matches on Subject: below --
2006-03-21 0:54 Sergei Shtylylov
2006-03-21 1:02 ` Martin Michlmayr
2006-03-21 1:05 ` Sergei Shtylylov
2006-03-22 12:01 ` Ralf Baechle
2006-05-25 18:47 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.