From: "Heiko Stübner" <heiko@sntech.de>
To: Markus Reichl <m.reichl@fivetechno.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jagan Teki <jagan@amarulasolutions.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] arm64: dts: rockchip: Split rk3399-roc-pc for with and without mezzanine board.
Date: Fri, 08 Nov 2019 17:52:35 +0100 [thread overview]
Message-ID: <4421021.f1aGTiCmcP@diego> (raw)
In-Reply-To: <616df0fa-a503-1a57-12b6-43bcd674db8c@fivetechno.de>
Hi Markus,
Am Freitag, 8. November 2019, 16:18:39 CET schrieb Markus Reichl:
> Am 08.11.19 um 15:41 schrieb Heiko Stübner:
> > Am Montag, 4. November 2019, 16:22:25 CET schrieb Markus Reichl:
> >> For rk3399-roc-pc is a mezzanine board available that carries M.2 and
> >> POE interfaces. Use it with a separate dts.
> >>
> >> ---
> >> v3: Use enum in binding and full name in compatible string and file name.
> >> v2: Add new compatible string for roc-pc with mezzanine board.
> >> --
> >>
> >> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> >> ---
> >> .../devicetree/bindings/arm/rockchip.yaml | 4 +-
> >> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> >> .../dts/rockchip/rk3399-roc-pc-mezzanine.dts | 72 ++
> >> .../arm64/boot/dts/rockchip/rk3399-roc-pc.dts | 757 +----------------
> >> .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 770 ++++++++++++++++++
> >> 5 files changed, 847 insertions(+), 757 deletions(-)
> >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts
> >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> >>
> >
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
> >> index 7e07dae33d0f..cd4195425309 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
> >> @@ -4,764 +4,9 @@
> >
> > This whole hunk fails to apply against my current branch for 5.5
> > which contain your other patches [0].
> >
> > And the moved block is obviously so big that I can't really check
> > which part is somehow different, so I'd ask you to rebase this
> > patch accordingly, so that it applies again.
>
> Yes, will rebase and come with v4.
Not wanting to put any pressure on you, but do you have an estimate
for this? I need to do my second (and final) round of pull requests for
v5.5, so it would of course be interesting if it's sensible to wait for
your respin ;-)
Thanks
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Markus Reichl <m.reichl@fivetechno.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] arm64: dts: rockchip: Split rk3399-roc-pc for with and without mezzanine board.
Date: Fri, 08 Nov 2019 17:52:35 +0100 [thread overview]
Message-ID: <4421021.f1aGTiCmcP@diego> (raw)
In-Reply-To: <616df0fa-a503-1a57-12b6-43bcd674db8c@fivetechno.de>
Hi Markus,
Am Freitag, 8. November 2019, 16:18:39 CET schrieb Markus Reichl:
> Am 08.11.19 um 15:41 schrieb Heiko Stübner:
> > Am Montag, 4. November 2019, 16:22:25 CET schrieb Markus Reichl:
> >> For rk3399-roc-pc is a mezzanine board available that carries M.2 and
> >> POE interfaces. Use it with a separate dts.
> >>
> >> ---
> >> v3: Use enum in binding and full name in compatible string and file name.
> >> v2: Add new compatible string for roc-pc with mezzanine board.
> >> --
> >>
> >> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> >> ---
> >> .../devicetree/bindings/arm/rockchip.yaml | 4 +-
> >> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> >> .../dts/rockchip/rk3399-roc-pc-mezzanine.dts | 72 ++
> >> .../arm64/boot/dts/rockchip/rk3399-roc-pc.dts | 757 +----------------
> >> .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 770 ++++++++++++++++++
> >> 5 files changed, 847 insertions(+), 757 deletions(-)
> >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts
> >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> >>
> >
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
> >> index 7e07dae33d0f..cd4195425309 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
> >> @@ -4,764 +4,9 @@
> >
> > This whole hunk fails to apply against my current branch for 5.5
> > which contain your other patches [0].
> >
> > And the moved block is obviously so big that I can't really check
> > which part is somehow different, so I'd ask you to rebase this
> > patch accordingly, so that it applies again.
>
> Yes, will rebase and come with v4.
Not wanting to put any pressure on you, but do you have an estimate
for this? I need to do my second (and final) round of pull requests for
v5.5, so it would of course be interesting if it's sensible to wait for
your respin ;-)
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-08 16:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 15:22 [PATCH v3] arm64: dts: rockchip: Split rk3399-roc-pc for with and without mezzanine board Markus Reichl
2019-11-04 15:22 ` Markus Reichl
2019-11-05 21:13 ` Rob Herring
2019-11-05 21:13 ` Rob Herring
2019-11-05 21:13 ` Rob Herring
2019-11-08 14:41 ` Heiko Stübner
2019-11-08 14:41 ` Heiko Stübner
2019-11-08 14:41 ` Heiko Stübner
2019-11-08 15:18 ` Markus Reichl
2019-11-08 15:18 ` Markus Reichl
2019-11-08 16:52 ` Heiko Stübner [this message]
2019-11-08 16:52 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4421021.f1aGTiCmcP@diego \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.