* Re: [Xen-changelog] Removed unused handler parameter from UnixXMLRPCServer interface -- just pass
[not found] <E1FMQAc-0001Ei-AW@xenbits.xensource.com>
@ 2006-03-23 19:59 ` Anthony Liguori
2006-03-23 20:05 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Anthony Liguori @ 2006-03-23 19:59 UTC (permalink / raw)
To: xen-devel; +Cc: Ewan Mellor
Xen patchbot -unstable wrote:
> # HG changeset patch
> # User emellor@leeni.uk.xensource.com
> # Node ID d52a93ee4624b0fae694353251622af2eb51dabc
> # Parent 8afbc25861219578fae30cc2a9bd60bf2ab26349
> Removed unused handler parameter from UnixXMLRPCServer interface -- just pass
> UnixXMLRPCRequestHandler through to TCPXMLRPCServer.
>
> Do not log requests -- this fills up xend-debug.log uselessly.
>
> Signed-off-by: Ewan Mellor <ewan@xensource.com>
>
> diff -r 8afbc2586121 -r d52a93ee4624 tools/python/xen/xend/server/XMLRPCServer.py
> --- a/tools/python/xen/xend/server/XMLRPCServer.py Thu Mar 23 10:30:33 2006
> +++ b/tools/python/xen/xend/server/XMLRPCServer.py Thu Mar 23 10:40:43 2006
> @@ -13,6 +13,7 @@
> # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> #============================================================================
> # Copyright (C) 2006 Anthony Liguori <aliguori@us.ibm.com>
> +# Copyright (C) 2006 XenSource Ltd
> #============================================================================
>
> from xen.xend import XendDomain, XendDomainInfo, XendNode, \
> @@ -69,9 +70,9 @@
> if self.use_tcp:
> # bind to something fixed for now as we may eliminate
> # tcp support completely.
> - self.server = TCPXMLRPCServer(("localhost", 8005))
> + self.server = TCPXMLRPCServer(("localhost", 8005, False))
>
This should be:
self.server = TCPXMLRPCServer(("localhost", 8005), False)
Regards,
Anthony Liguori
> else:
> - self.server = UnixXMLRPCServer(XML_RPC_SOCKET)
> + self.server = UnixXMLRPCServer(XML_RPC_SOCKET, False)
>
> # Functions in XendDomainInfo
> for name in methods:
>
> _______________________________________________
> Xen-changelog mailing list
> Xen-changelog@lists.xensource.com
> http://lists.xensource.com/xen-changelog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Re: [Xen-changelog] Removed unused handler parameter from UnixXMLRPCServer interface -- just pass
2006-03-23 19:59 ` [Xen-changelog] Removed unused handler parameter from UnixXMLRPCServer interface -- just pass Anthony Liguori
@ 2006-03-23 20:05 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2006-03-23 20:05 UTC (permalink / raw)
To: xen-devel; +Cc: Ewan Mellor
Anthony Liguori wrote:
> Xen patchbot -unstable wrote:
>> # HG changeset patch
>> # User emellor@leeni.uk.xensource.com
>> # Node ID d52a93ee4624b0fae694353251622af2eb51dabc
>> # Parent 8afbc25861219578fae30cc2a9bd60bf2ab26349
>> Removed unused handler parameter from UnixXMLRPCServer interface --
>> just pass
>> UnixXMLRPCRequestHandler through to TCPXMLRPCServer.
>>
>> Do not log requests -- this fills up xend-debug.log uselessly.
>>
>> Signed-off-by: Ewan Mellor <ewan@xensource.com>
>>
>> diff -r 8afbc2586121 -r d52a93ee4624
>> tools/python/xen/xend/server/XMLRPCServer.py
>> --- a/tools/python/xen/xend/server/XMLRPCServer.py Thu Mar 23
>> 10:30:33 2006
>> +++ b/tools/python/xen/xend/server/XMLRPCServer.py Thu Mar 23
>> 10:40:43 2006
>> @@ -13,6 +13,7 @@
>> # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
>> 02111-1307 USA
>> #============================================================================
>>
>> # Copyright (C) 2006 Anthony Liguori <aliguori@us.ibm.com>
>> +# Copyright (C) 2006 XenSource Ltd
>> #============================================================================
>>
>>
>> from xen.xend import XendDomain, XendDomainInfo, XendNode, \
>> @@ -69,9 +70,9 @@
>> if self.use_tcp:
>> # bind to something fixed for now as we may eliminate
>> # tcp support completely.
>> - self.server = TCPXMLRPCServer(("localhost", 8005))
>> + self.server = TCPXMLRPCServer(("localhost", 8005, False))
>>
>
> This should be:
>
> self.server = TCPXMLRPCServer(("localhost", 8005), False)
Sorry, it should actually be:
self.server = TCPXMLRPCServer(("localhost, 8005), logRequests=False)
Regards,
Anthony Liguori
> Regards,
>
> Anthony Liguori
>
>> else:
>> - self.server = UnixXMLRPCServer(XML_RPC_SOCKET)
>> + self.server = UnixXMLRPCServer(XML_RPC_SOCKET, False)
>>
>> # Functions in XendDomainInfo
>> for name in methods:
>>
>> _______________________________________________
>> Xen-changelog mailing list
>> Xen-changelog@lists.xensource.com
>> http://lists.xensource.com/xen-changelog
>>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-03-23 20:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1FMQAc-0001Ei-AW@xenbits.xensource.com>
2006-03-23 19:59 ` [Xen-changelog] Removed unused handler parameter from UnixXMLRPCServer interface -- just pass Anthony Liguori
2006-03-23 20:05 ` Anthony Liguori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.