From: Patrick McHardy <kaber@trash.net>
To: Adrian Bunk <bunk@stusta.de>
Cc: netdev@vger.kernel.org, zhaojingmin@users.sourceforge.net,
netfilter-devel@lists.netfilter.org,
Jing Min Zhao <zhaojignmin@hotmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: Two comments on the H.323 conntrack/NAT helper
Date: Fri, 24 Mar 2006 03:02:12 +0100 [thread overview]
Message-ID: <44235324.3080607@trash.net> (raw)
In-Reply-To: <20060324001307.GO22727@stusta.de>
[The hotmail address of the author doesn't work, CCed sourceforge-address]
Adrian Bunk wrote:
> Two comments on the H.323 conntrack/NAT helper:
> - the function prototypes in ip_nat_helper_h323.c are _ugly_,
> please move them to a header file
Their ugliness is because of the current API, which cleaned up
quite a lot of the surrounding code, but requires this ugliness
from each helper. I would like to keep them visible as a reminder
that a cleaner solution is wanted, but moving them to header
files certainly sound like a good idea to eliminate the risk
of prototype conflicts. But please do this for all helpers
at once.
> - is there a reason for not using EXPORT_SYMBOL_GPL?
I would prefer that too.
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: Adrian Bunk <bunk@stusta.de>
Cc: Jing Min Zhao <zhaojignmin@hotmail.com>,
netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org,
linux-kernel@vger.kernel.org, zhaojingmin@users.sourceforge.net
Subject: Re: Two comments on the H.323 conntrack/NAT helper
Date: Fri, 24 Mar 2006 03:02:12 +0100 [thread overview]
Message-ID: <44235324.3080607@trash.net> (raw)
In-Reply-To: <20060324001307.GO22727@stusta.de>
[The hotmail address of the author doesn't work, CCed sourceforge-address]
Adrian Bunk wrote:
> Two comments on the H.323 conntrack/NAT helper:
> - the function prototypes in ip_nat_helper_h323.c are _ugly_,
> please move them to a header file
Their ugliness is because of the current API, which cleaned up
quite a lot of the surrounding code, but requires this ugliness
from each helper. I would like to keep them visible as a reminder
that a cleaner solution is wanted, but moving them to header
files certainly sound like a good idea to eliminate the risk
of prototype conflicts. But please do this for all helpers
at once.
> - is there a reason for not using EXPORT_SYMBOL_GPL?
I would prefer that too.
next prev parent reply other threads:[~2006-03-24 2:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 0:13 Two comments on the H.323 conntrack/NAT helper Adrian Bunk
2006-03-24 0:13 ` Adrian Bunk
2006-03-24 2:02 ` Patrick McHardy [this message]
2006-03-24 2:02 ` Patrick McHardy
2006-03-24 2:40 ` Jing Min Zhao
2006-03-24 2:40 ` Jing Min Zhao
2006-03-24 19:02 ` Jing Min Zhao
2006-03-24 19:02 ` Jing Min Zhao
2006-03-29 10:09 ` Patrick McHardy
2006-03-29 17:25 ` Jing Min Zhao
2006-03-24 2:34 ` Jing Min Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44235324.3080607@trash.net \
--to=kaber@trash.net \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=zhaojignmin@hotmail.com \
--cc=zhaojingmin@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.