From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, Stefan Weil <sw@weilnetz.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [BUG] 216 Alerts reported by LGTM for QEMU (some might be release critical)
Date: Mon, 15 Jul 2019 08:08:29 +0000 [thread overview]
Message-ID: <442551a1-bb10-3fb1-efa4-3f8df184ac03@linaro.org> (raw)
In-Reply-To: <CAFEAcA-ZEsX2nf7OmLmBE+v3VLHYQo60m8Vay28o7VNVgcn_ig@mail.gmail.com>
On 7/14/19 5:30 PM, Peter Maydell wrote:
> I had a look at some of these before, but mostly I came
> to the conclusion that it wasn't worth trying to put the
> effort into keeping up with the site because they didn't
> seem to provide any useful way to mark things as false
> positives. Coverity has its flaws but at least you can do
> that kind of thing in its UI (it runs at about a 33% fp
> rate, I think.)
Yes, LGTM wants you to modify the source code with
/* lgtm [cpp/some-warning-code] */
and on the same line as the reported problem. Which is mildly annoying in that
you're definitely committing to LGTM in the long term. Also for any
non-trivial bit of code, it will almost certainly run over 80 columns.
r~
prev parent reply other threads:[~2019-07-15 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 17:46 [Qemu-devel] [BUG] 216 Alerts reported by LGTM for QEMU (some might be release critical) Stefan Weil
2019-07-13 19:42 ` Paolo Bonzini
2019-07-14 13:28 ` Stefan Weil
2019-07-15 8:26 ` Kevin Wolf
2019-07-14 17:30 ` Peter Maydell
2019-07-14 17:44 ` Stefan Weil
2019-07-15 5:10 ` Markus Armbruster
2019-07-15 8:08 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442551a1-bb10-3fb1-efa4-3f8df184ac03@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.