From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [BUG] 216 Alerts reported by LGTM for QEMU (some might be release critical)
Date: Sat, 13 Jul 2019 21:42:03 +0200 [thread overview]
Message-ID: <f3735415-bd75-8ed6-1dc7-ff51cc7ab03f@redhat.com> (raw)
In-Reply-To: <030a439f-bb17-8232-bd1c-3585905e8feb@weilnetz.de>
On 13/07/19 19:46, Stefan Weil wrote:
>
> LGTM reports 16 errors, 81 warnings and 119 recommendations:
> https://lgtm.com/projects/g/qemu/qemu/alerts/?mode=list.
>
> Some of them are already know (wrong format strings), others look like
> real errors:
>
> - several multiplication results which don't work as they should in
> contrib/vhost-user-gpu, block/* (m->nb_clusters * s->cluster_size only
> 32 bit!), target/i386/translate.c and other files
m->nb_clusters here is limited by s->l2_slice_size (see for example
handle_alloc) so I wouldn't be surprised if this is a false positive. I
couldn't find this particular multiplication in Coverity, but it has
about 250 issues marked as intentional or false positive so there's
probably a lot of overlap with what LGTM found.
Paolo
next prev parent reply other threads:[~2019-07-13 19:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 17:46 [Qemu-devel] [BUG] 216 Alerts reported by LGTM for QEMU (some might be release critical) Stefan Weil
2019-07-13 19:42 ` Paolo Bonzini [this message]
2019-07-14 13:28 ` Stefan Weil
2019-07-15 8:26 ` Kevin Wolf
2019-07-14 17:30 ` Peter Maydell
2019-07-14 17:44 ` Stefan Weil
2019-07-15 5:10 ` Markus Armbruster
2019-07-15 8:08 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3735415-bd75-8ed6-1dc7-ff51cc7ab03f@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.