* [PATCH] ip_conntrack_netlink : fix expectation notifier unregistration
@ 2006-03-26 14:19 Martin Josefsson
2006-03-28 13:28 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Martin Josefsson @ 2006-03-26 14:19 UTC (permalink / raw)
To: Patrick McHardy; +Cc: netfilter-devel
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
Same fix as for the notifier unregistration bug in nf_conntrack_netlink.
This patch fixes expectation notifier unregistration on module unload to
use ip_conntrack_expect_unregister_notifier(). This bug causes a soft
lockup at the first expectation created after a rmmod ; insmod of this
module.
Should go into -stable as well.
Signed-off-by: Martin Josefsson <gandalf@wlug.westbo.se>
--- linux-2.6.16.orig/net/ipv4/netfilter/ip_conntrack_netlink.c 2006-03-20 06:53:29.000000000 +0100
+++ linux-2.6.16/net/ipv4/netfilter/ip_conntrack_netlink.c 2006-03-26 16:13:58.000000000 +0200
@@ -1619,7 +1619,7 @@ static void __exit ctnetlink_exit(void)
printk("ctnetlink: unregistering from nfnetlink.\n");
#ifdef CONFIG_IP_NF_CONNTRACK_EVENTS
- ip_conntrack_unregister_notifier(&ctnl_notifier_exp);
+ ip_conntrack_expect_unregister_notifier(&ctnl_notifier_exp);
ip_conntrack_unregister_notifier(&ctnl_notifier);
#endif
--
/Martin
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ip_conntrack_netlink : fix expectation notifier unregistration
2006-03-26 14:19 [PATCH] ip_conntrack_netlink : fix expectation notifier unregistration Martin Josefsson
@ 2006-03-28 13:28 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2006-03-28 13:28 UTC (permalink / raw)
To: Martin Josefsson; +Cc: netfilter-devel
Martin Josefsson wrote:
> Same fix as for the notifier unregistration bug in nf_conntrack_netlink.
>
> This patch fixes expectation notifier unregistration on module unload to
> use ip_conntrack_expect_unregister_notifier(). This bug causes a soft
> lockup at the first expectation created after a rmmod ; insmod of this
> module.
>
> Should go into -stable as well.
Applied to my tree, I'll pass them on soon (probably tonight).
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-03-28 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-26 14:19 [PATCH] ip_conntrack_netlink : fix expectation notifier unregistration Martin Josefsson
2006-03-28 13:28 ` Patrick McHardy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.