From: Alexander Belyakov <alexander.belyakov@intel.com>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: "Korolev, Alexey" <alexey.korolev@intel.com>,
linux-mtd@lists.infradead.org, "Kutergin,
Timofey" <timofey.kutergin@intel.com>
Subject: Re: [PATCH/RFC] MTD: Striping layer core
Date: Fri, 31 Mar 2006 10:52:59 +0400 [thread overview]
Message-ID: <442CD1CB.7050509@intel.com> (raw)
In-Reply-To: <20060330121156.GA31749@wohnheim.fh-wedel.de>
Jörn Engel wrote:
> On Thu, 30 March 2006 11:57:37 +0400, Belyakov, Alexander wrote:
>> diff -uNr a/drivers/mtd/maps/mphysmap.c b/drivers/mtd/maps/mphysmap.c
>> --- a/drivers/mtd/maps/mphysmap.c 2006-03-28 12:08:28.000000000
>> +0400
>> +++ b/drivers/mtd/maps/mphysmap.c 2006-03-28 12:10:48.000000000
>> +0400
>> @@ -12,6 +12,9 @@
>> #ifdef CONFIG_MTD_PARTITIONS
>> #include <linux/mtd/partitions.h>
>> #endif
>> +#ifdef CONFIG_MTD_CMDLINE_STRIPE
>> +#include <linux/mtd/stripe.h>
>> +#endif
>
> Move the #ifdef into the header.
May I ask what is the reason for that (taking into account that
partitions.h is already included here the same way for the same purpose)?
> Your code suffers from a lot of very basic things that make it hard to
> review.
What exactly you wish to see here? Hope I can bring clarifications by
changing code/comments or via this mailing list.
Thanks,
Alexander Belyakov
next prev parent reply other threads:[~2006-03-31 6:53 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-30 7:57 [PATCH/RFC] MTD: Striping layer core Belyakov, Alexander
2006-03-30 9:06 ` Vitaly Wool
2006-03-30 11:50 ` Artem B. Bityutskiy
2006-03-30 12:15 ` Vitaly Wool
2006-03-30 15:24 ` Alexander Belyakov
2006-03-30 15:39 ` Artem B. Bityutskiy
2006-03-31 7:06 ` Alexander Belyakov
2006-03-31 8:02 ` Artem B. Bityutskiy
2006-03-31 8:05 ` Artem B. Bityutskiy
2006-03-31 8:17 ` Alexander Belyakov
2006-03-31 8:38 ` Artem B. Bityutskiy
2006-03-31 8:55 ` Artem B. Bityutskiy
2006-03-31 16:59 ` Nicolas Pitre
2006-04-02 11:22 ` Artem B. Bityutskiy
2006-03-31 9:27 ` Jörn Engel
2006-03-31 9:36 ` Artem B. Bityutskiy
2006-03-31 9:40 ` Jörn Engel
2006-03-31 10:00 ` Artem B. Bityutskiy
2006-03-31 10:06 ` Artem B. Bityutskiy
2006-03-31 10:07 ` Jörn Engel
2006-03-31 10:18 ` Artem B. Bityutskiy
2006-03-31 11:40 ` Jörn Engel
2006-03-31 11:47 ` Artem B. Bityutskiy
2006-03-31 11:56 ` Jörn Engel
2006-03-31 12:06 ` Artem B. Bityutskiy
2006-03-31 11:55 ` Artem B. Bityutskiy
2006-03-31 11:59 ` Jörn Engel
2006-03-31 12:11 ` Artem B. Bityutskiy
2006-03-31 12:20 ` Jörn Engel
2006-03-31 12:28 ` Artem B. Bityutskiy
2006-03-31 12:57 ` Jörn Engel
2006-03-31 13:08 ` Artem B. Bityutskiy
2006-03-31 17:22 ` Nicolas Pitre
2006-04-03 13:06 ` Jörn Engel
2006-04-03 13:18 ` Jörn Engel
2006-04-04 1:39 ` Josh Boyer
2006-04-04 1:41 ` Josh Boyer
2006-03-31 17:19 ` Nicolas Pitre
2006-04-02 12:34 ` Artem B. Bityutskiy
2006-03-31 17:14 ` Nicolas Pitre
2006-04-02 12:11 ` Artem B. Bityutskiy
2006-03-31 17:06 ` Nicolas Pitre
2006-03-31 16:49 ` Nicolas Pitre
2006-04-02 10:51 ` Artem B. Bityutskiy
2006-04-03 4:06 ` Vitaly Wool
2006-04-03 6:04 ` Thomas Gleixner
2006-04-03 6:14 ` Vitaly Wool
2006-04-03 6:21 ` Thomas Gleixner
2006-04-03 6:59 ` Artem B. Bityutskiy
2006-04-03 7:20 ` Alexander Belyakov
2006-04-03 13:44 ` Nicolas Pitre
2006-03-30 10:35 ` Artem B. Bityutskiy
2006-03-30 15:38 ` Alexander Belyakov
2006-03-30 16:32 ` Nicolas Pitre
2006-03-30 16:38 ` Artem B. Bityutskiy
2006-03-30 16:56 ` Jared Hulbert
2006-03-30 17:03 ` Artem B. Bityutskiy
2006-03-31 7:19 ` Alexander Belyakov
2006-03-30 12:11 ` Jörn Engel
2006-03-31 6:52 ` Alexander Belyakov [this message]
2006-03-31 7:57 ` Artem B. Bityutskiy
2006-03-31 8:11 ` Alexander Belyakov
2006-03-31 8:31 ` Artem B. Bityutskiy
2006-03-31 8:35 ` Alexander Belyakov
2006-03-31 8:47 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442CD1CB.7050509@intel.com \
--to=alexander.belyakov@intel.com \
--cc=alexey.korolev@intel.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-mtd@lists.infradead.org \
--cc=timofey.kutergin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.