* [PATCH] Fix reversed test in balloon.py
@ 2006-03-31 19:26 Charles Coffing
0 siblings, 0 replies; only message in thread
From: Charles Coffing @ 2006-03-31 19:26 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
When dom0 fails to balloon enough memory to allow a new domain to start,
an exception is thrown. The test that decides which exception to throw
is backwards, resulting in strange error messages. The attached patch
fixes the problem.
Signed-off-by: Charles Coffing <ccoffing@novell.com>
[-- Attachment #2: xen-balloon.diff --]
[-- Type: application/octet-stream, Size: 614 bytes --]
--- xen-unstable-1/tools/python/xen/xend/balloon.py 2006-03-14 12:50:58.000000000 -0700
+++ xen-unstable-2/tools/python/xen/xend/balloon.py 2006-03-31 11:35:20.000000000 -0700
@@ -152,7 +152,7 @@
'I cannot release any more. I need %d MiB but '
'only have %d.') %
(need_mem, free_mem))
- elif new_alloc >= dom0_min_mem:
+ elif new_alloc < dom0_min_mem:
raise VmError(
('I need %d MiB, but dom0_min_mem is %d and shrinking to '
'%d MiB would leave only %d MiB free.') %
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-03-31 19:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-31 19:26 [PATCH] Fix reversed test in balloon.py Charles Coffing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.