[SEPOL] Fix leak of optional package sections

[SEPOL] Fix leak of optional package sections

[Ivan Gyurdiev]

[-- Attachment #1: Type: text/plain, Size: 96 bytes --]

Sometimes it pays off to wait 5+ minutes for valgrind to process the 
semanage strict commit :)

[-- Attachment #2: libsepol.optionals_leak.diff --]
[-- Type: text/x-patch, Size: 742 bytes --]

diff -Naurp --exclude-from excludes old/libsepol/src/module.c new/libsepol/src/module.c
--- old/libsepol/src/module.c	2006-03-29 14:34:12.000000000 -0500
+++ new/libsepol/src/module.c	2006-03-31 13:02:23.000000000 -0500
@@ -112,12 +112,14 @@ hidden_def(sepol_module_package_create)
  * the pointer itself.  Does nothing if p is NULL.
  */
 void sepol_module_package_free(sepol_module_package_t *p) {
-        if (p == NULL) {
-                return;
-        }
-        sepol_policydb_free(p->policy);
-        free(p->file_contexts);
-        free(p);
+	if (p == NULL)
+		return;
+
+	sepol_policydb_free(p->policy);
+	free(p->file_contexts);
+	free(p->seusers);
+	free(p->user_extra);
+	free(p);
 }
 hidden_def(sepol_module_package_free)
 

Re: [SEPOL] Fix leak of optional package sections

[Stephen Smalley]

On Fri, 2006-03-31 at 13:12 -0500, Ivan Gyurdiev wrote:
> Sometimes it pays off to wait 5+ minutes for valgrind to process the 
> semanage strict commit :)

Thanks, merged internally.  sourceforge cvs is presently broken, so not
there yet.

-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.