From: r.marek@sh.cvut.cz (Rudolf Marek)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] W83627EHF driver enhancements
Date: Sun, 02 Apr 2006 10:09:27 +0000 [thread overview]
Message-ID: <442FA2D7.5080501@sh.cvut.cz> (raw)
In-Reply-To: <442ED616.4070109@sh.cvut.cz>
David Hubbard wrote:
> Hi Rudolf,
>
> Okay, thanks for the reply! I just moved but I have my computer
> intact. :-) So let's go with the steps you proposed. (My email isn't
> completely set up, so I'm pasting it in)
>
>> 1) I will document that we have 0 for DC and 1 for PWM (patch to kernel doc)
>> 2) You will send me the patch on the top of that one from 23.3 that
>> fixes the DC 0 and PWM 1 plus the manual stuff, optionaly you may
>> include the new RPM cruise files features. This can be done in one
>> patch because it is just "our" internal step. When we are done with
>> this I will post the final patch and submit it to Jean for inclusion
>> 3) Now you can send the cleanup patch on the top of previous patch
>> (With the Signed-off-by stuff)
>
> I'm ready to go, but can I send you a patch from the w83627ehf.c that
> you sent me? That's the first one that I understood. (I'm learning
> about git and how lm-sensors sends patches upstream.)
You need the file I sent to you plus the fancrt patch on the top of it. This will create
the file with all alarms voltages EHF driver, then when fancrt is applied you have the
current base to start on it.
Do your changes and when done just diff to same file but with your changes (so simply the ehf driver that I sent to you plus the fancrt patch)
> I'll send a patch that has these things:
> 1. switch DC 0 PWM 1
> 2. new RPM cruise modes
Good that is what I want to see.
> I didn't get what you wanted with the whitespace changes...
Now you get it ;) We cannot mix more stuff together. The patch should either add features/modify or do the cleanup.
Regards
Rudolf
next prev parent reply other threads:[~2006-04-02 10:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-01 19:35 [lm-sensors] W83627EHF driver enhancements Rudolf Marek
2006-04-02 5:43 ` David Hubbard
2006-04-02 5:46 ` David Hubbard
2006-04-02 10:09 ` Rudolf Marek [this message]
2006-04-12 1:04 ` David Hubbard
2006-04-16 21:21 ` Rudolf Marek
2006-05-10 17:07 ` Rudolf Marek
2006-05-10 19:01 ` David Hubbard
2006-05-10 19:12 ` Rudolf Marek
2006-05-10 20:25 ` David Hubbard
2006-05-11 15:25 ` David Hubbard
2006-05-12 6:44 ` Sylvain Jeaugey
2006-05-14 20:55 ` Rudolf Marek
2006-05-15 14:14 ` David Hubbard
2006-05-15 16:47 ` Jean Delvare
2006-05-15 18:37 ` Sylvain Jeaugey
2006-05-15 20:17 ` David Hubbard
2006-05-15 21:11 ` Rudolf Marek
2006-05-20 13:57 ` Rudolf Marek
2006-06-04 18:08 ` Rudolf Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442FA2D7.5080501@sh.cvut.cz \
--to=r.marek@sh.cvut.cz \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.