All of lore.kernel.org
 help / color / mirror / Atom feed
From: r.marek@sh.cvut.cz (Rudolf Marek)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] W83627EHF driver enhancements
Date: Sun, 14 May 2006 20:55:54 +0000	[thread overview]
Message-ID: <4467995A.9090905@sh.cvut.cz> (raw)
In-Reply-To: <442ED616.4070109@sh.cvut.cz>

Hi all

> Trying to build against 2.6.16.16, I ran into undefined references to
> SENSOR_ATTR arrays. After a quick search it looks like it was introduced
> little time ago.

> Do I need to upgrade to 2.6.17-rc4 or is there another separate patch to
> apply ?

upgrade to this kernel version plus use supplied w83627ehf.c

It should work with that - but David fixed one of the patches by hand and it is
malformed now. I will post tomorrow bigger patch putting together what we have
until now.

David, do you have somewhere the speed cruise mode or we postpone it to later?
I went through your patches and they look good to me, I just fixed a codingstyle
on some place plus I want to verify some of your changes, I will do that tomorrow.

plan:

1) I will merge yours patches to one bigger (tomorrow)
2) I have fixed the sysfs docs and I post them (tomorrow)
3) I still think that check for fan4 and fan5 is not sufficient.
   see page 94 (printed) in datasheet, the pin 119 can be GPIO,
   similar for other fan which is shared with serial flash interface,
   but it seems the datasheet is not sharing with us the pin control.

PI) speed cruise mode patch ?
4) cleanup patch for whole file
5) docs update reflecting the fan control (got some notes about the files)

Personally I think we can wait with fanspeed cruise a bit and concentrate to
finish our stuff...


Regards
Rudolf


  parent reply	other threads:[~2006-05-14 20:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-01 19:35 [lm-sensors] W83627EHF driver enhancements Rudolf Marek
2006-04-02  5:43 ` David Hubbard
2006-04-02  5:46 ` David Hubbard
2006-04-02 10:09 ` Rudolf Marek
2006-04-12  1:04 ` David Hubbard
2006-04-16 21:21 ` Rudolf Marek
2006-05-10 17:07 ` Rudolf Marek
2006-05-10 19:01 ` David Hubbard
2006-05-10 19:12 ` Rudolf Marek
2006-05-10 20:25 ` David Hubbard
2006-05-11 15:25 ` David Hubbard
2006-05-12  6:44 ` Sylvain Jeaugey
2006-05-14 20:55 ` Rudolf Marek [this message]
2006-05-15 14:14 ` David Hubbard
2006-05-15 16:47 ` Jean Delvare
2006-05-15 18:37 ` Sylvain Jeaugey
2006-05-15 20:17 ` David Hubbard
2006-05-15 21:11 ` Rudolf Marek
2006-05-20 13:57 ` Rudolf Marek
2006-06-04 18:08 ` Rudolf Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4467995A.9090905@sh.cvut.cz \
    --to=r.marek@sh.cvut.cz \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.