Re: [LTP] [PATCH V2] getrusage03: disable the test when kernel before 2.6.32

Re: [LTP] [PATCH V2] getrusage03: disable the test when kernel before 2.6.32

[Jan Stancek]

----- Original Message -----
> From: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
> To: "LTP" <ltp-list@lists.sourceforge.net>
> Cc: "Cyril Hrubis" <chrubis@suse.cz>, "Caspar Zhang" <caspar@casparzhang.com>, "Garrett Cooper" <yanegomi@gmail.com>,
> "Mike Frysinger" <vapier@gentoo.org>, jstancek@redhat.com, "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
> Sent: Tuesday, 25 June, 2013 3:33:50 AM
> Subject: [PATCH V2] getrusage03: disable the test when kernel before 2.6.32
> 
> Kernel commit 1f10206c is first introduced in 2.6.32, this
> ru_maxrss behaviors will not be supported before kernel 2.6.32,
> so disable the test when kernel version is before 2.6.32.
> 
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

Looks good to me.
Reviewed-by: Jan Stancek <jstancek@redhat.com>

Regards,
Jan

> ---
>  testcases/kernel/syscalls/getrusage/getrusage03.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/testcases/kernel/syscalls/getrusage/getrusage03.c
> b/testcases/kernel/syscalls/getrusage/getrusage03.c
> index 202356c..5d82a94 100644
> --- a/testcases/kernel/syscalls/getrusage/getrusage03.c
> +++ b/testcases/kernel/syscalls/getrusage/getrusage03.c
> @@ -346,6 +346,13 @@ static void consume(int mega)
>  
>  static void setup(void)
>  {
> +	/* Disable test if the version of the kernel is less than 2.6.32 */
> +	if ((tst_kvercmp(2, 6, 32)) < 0) {
> +		tst_resm(TCONF, "This ru_maxrss field is not supported");
> +		tst_resm(TCONF, "before kernel 2.6.32");
> +		tst_exit();
> +	}
> +
>  	tst_sig(FORK, DEF_HANDLER, cleanup);
>  
>  	TEST_PAUSE;
> --
> 1.8.3.1.448.gfb7dfaa
> 
> 

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH V2] getrusage03: disable the test when kernel before 2.6.32

[chrubis]

Hi!
> Kernel commit 1f10206c is first introduced in 2.6.32, this
> ru_maxrss behaviors will not be supported before kernel 2.6.32,
> so disable the test when kernel version is before 2.6.32.

Pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list