All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Kuehling <felix.kuehling@amd.com>
To: Atul Raut <rauji.raut@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/amdkfd: Use memdup_user() rather than duplicating its implementation
Date: Wed, 9 Aug 2023 15:12:18 -0400	[thread overview]
Message-ID: <44377060-25b4-adaa-d003-210434b94de2@amd.com> (raw)
In-Reply-To: <20230809053018.88004-1-rauji.raut@gmail.com>


On 2023-08-09 01:30, Atul Raut wrote:
> To prevent its redundant implementation and streamline
> code, use memdup_user.
>
> This fixes warnings reported by Coccinelle:
> ./drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c:2811:13-20: WARNING opportunity for memdup_user
>
> Signed-off-by: Atul Raut <rauji.raut@gmail.com>

The patch is

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>

I'm applying it to amd-staging-drm-next.

Regards,
   Felix


> ---
> v1 -> v2
>    caller checks for errors, hence removed
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 10 +---------
>   1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 2df153828ff4..df9b618756e6 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -2803,19 +2803,11 @@ static void copy_context_work_handler (struct work_struct *work)
>   static uint32_t *get_queue_ids(uint32_t num_queues, uint32_t *usr_queue_id_array)
>   {
>   	size_t array_size = num_queues * sizeof(uint32_t);
> -	uint32_t *queue_ids = NULL;
>   
>   	if (!usr_queue_id_array)
>   		return NULL;
>   
> -	queue_ids = kzalloc(array_size, GFP_KERNEL);
> -	if (!queue_ids)
> -		return ERR_PTR(-ENOMEM);
> -
> -	if (copy_from_user(queue_ids, usr_queue_id_array, array_size))
> -		return ERR_PTR(-EFAULT);
> -
> -	return queue_ids;
> +	return memdup_user(usr_queue_id_array, array_size);
>   }
>   
>   int resume_queues(struct kfd_process *p,

WARNING: multiple messages have this Message-ID (diff)
From: Felix Kuehling via Linux-kernel-mentees <linux-kernel-mentees@lists.linuxfoundation.org>
To: Atul Raut <rauji.raut@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/amdkfd: Use memdup_user() rather than duplicating its implementation
Date: Wed, 9 Aug 2023 15:12:18 -0400	[thread overview]
Message-ID: <44377060-25b4-adaa-d003-210434b94de2@amd.com> (raw)
In-Reply-To: <20230809053018.88004-1-rauji.raut@gmail.com>


On 2023-08-09 01:30, Atul Raut wrote:
> To prevent its redundant implementation and streamline
> code, use memdup_user.
>
> This fixes warnings reported by Coccinelle:
> ./drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c:2811:13-20: WARNING opportunity for memdup_user
>
> Signed-off-by: Atul Raut <rauji.raut@gmail.com>

The patch is

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>

I'm applying it to amd-staging-drm-next.

Regards,
   Felix


> ---
> v1 -> v2
>    caller checks for errors, hence removed
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 10 +---------
>   1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 2df153828ff4..df9b618756e6 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -2803,19 +2803,11 @@ static void copy_context_work_handler (struct work_struct *work)
>   static uint32_t *get_queue_ids(uint32_t num_queues, uint32_t *usr_queue_id_array)
>   {
>   	size_t array_size = num_queues * sizeof(uint32_t);
> -	uint32_t *queue_ids = NULL;
>   
>   	if (!usr_queue_id_array)
>   		return NULL;
>   
> -	queue_ids = kzalloc(array_size, GFP_KERNEL);
> -	if (!queue_ids)
> -		return ERR_PTR(-ENOMEM);
> -
> -	if (copy_from_user(queue_ids, usr_queue_id_array, array_size))
> -		return ERR_PTR(-EFAULT);
> -
> -	return queue_ids;
> +	return memdup_user(usr_queue_id_array, array_size);
>   }
>   
>   int resume_queues(struct kfd_process *p,
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2023-08-09 19:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09  5:30 [PATCH v2] drm/amdkfd: Use memdup_user() rather than duplicating its implementation Atul Raut
2023-08-09  5:30 ` Atul Raut
2023-08-09 19:12 ` Felix Kuehling [this message]
2023-08-09 19:12   ` Felix Kuehling via Linux-kernel-mentees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44377060-25b4-adaa-d003-210434b94de2@amd.com \
    --to=felix.kuehling@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=rauji.raut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.