All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Missing CDROM media (w/Signed-off-by)
@ 2006-04-11 15:42 Ross Maxfield
  2006-04-11 16:00 ` Anthony Liguori
  0 siblings, 1 reply; 2+ messages in thread
From: Ross Maxfield @ 2006-04-11 15:42 UTC (permalink / raw)
  To: xen-devel

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

All,
Being a neophyte to open-source checkins, I apologize for the failure to include the 'Signed-off-by' statement, and resubmit the missing-media patch in conformation.

- Ross 

Signed-off-by: Ross Maxfield <rmaxfiel@novell.com>


[-- Attachment #2: xen-missing-media.diff --]
[-- Type: application/octet-stream, Size: 828 bytes --]

Index: xen-3.0-testing/tools/ioemu/vl.c
===================================================================
--- xen-3.0-testing.orig/tools/ioemu/vl.c
+++ xen-3.0-testing/tools/ioemu/vl.c
@@ -3243,8 +3243,17 @@ int main(int argc, char **argv)
     /* we always create the cdrom drive, even if no disk is there */
     bdrv_init();
     if (has_cdrom) {
-        bs_table[2] = bdrv_new("cdrom");
-        bdrv_set_type_hint(bs_table[2], BDRV_TYPE_CDROM);
+	int fd;
+        if ( (fd = open(hd_filename[2], O_RDONLY | O_BINARY)) < 0) {
+  		fprintf(stderr, "Could not open CD %s.\n", hd_filename[i]);
+		hd_filename[2]=NULL;
+		bs_table[2]=NULL;
+	}
+	else {
+		close(fd);
+	        bs_table[2] = bdrv_new("cdrom");
+	        bdrv_set_type_hint(bs_table[2], BDRV_TYPE_CDROM);
+	}
     }
 
     /* open the virtual block devices */

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Missing CDROM media (w/Signed-off-by)
  2006-04-11 15:42 [PATCH] Missing CDROM media (w/Signed-off-by) Ross Maxfield
@ 2006-04-11 16:00 ` Anthony Liguori
  0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2006-04-11 16:00 UTC (permalink / raw)
  To: Ross Maxfield; +Cc: xen-devel

Thanks!

Regards,

Anthony Liguori

Ross Maxfield wrote:
> All,
> Being a neophyte to open-source checkins, I apologize for the failure to include the 'Signed-off-by' statement, and resubmit the missing-media patch in conformation.
>
> - Ross 
>
> Signed-off-by: Ross Maxfield <rmaxfiel@novell.com>
>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>   

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-04-11 16:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-11 15:42 [PATCH] Missing CDROM media (w/Signed-off-by) Ross Maxfield
2006-04-11 16:00 ` Anthony Liguori

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.