From: Corey Minyard <cminyard@mvista.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>,
minyard@mvista.com
Subject: Re: [PATCH] IPMI: fix devinit placement
Date: Wed, 12 Apr 2006 13:22:45 -0500 [thread overview]
Message-ID: <443D4575.1090506@mvista.com> (raw)
In-Reply-To: <20060412110557.dc03c0f8.rdunlap@xenotime.net>
Looks fine to me. Thanks.
-Corey
Randy.Dunlap wrote:
>From: Randy Dunlap <rdunlap@xenotime.net>
>
>gcc complains about __devinit in the wrong location:
>drivers/char/ipmi/ipmi_si_intf.c:2205: warning: '__section__' attribute does not apply to types
>
>Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>---
> drivers/char/ipmi/ipmi_si_intf.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>--- linux-2617-rc1g5.orig/drivers/char/ipmi/ipmi_si_intf.c
>+++ linux-2617-rc1g5/drivers/char/ipmi/ipmi_si_intf.c
>@@ -2198,11 +2198,11 @@ static inline void wait_for_timer_and_th
> }
> }
>
>-static struct ipmi_default_vals
>+static __devinit struct ipmi_default_vals
> {
> int type;
> int port;
>-} __devinit ipmi_defaults[] =
>+} ipmi_defaults[] =
> {
> { .type = SI_KCS, .port = 0xca2 },
> { .type = SI_SMIC, .port = 0xca9 },
>
>
>---
>
>
next prev parent reply other threads:[~2006-04-12 18:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-12 18:05 [PATCH] IPMI: fix devinit placement Randy.Dunlap
2006-04-12 18:22 ` Corey Minyard [this message]
2006-04-13 5:31 ` [PATCH] IPMI: fix devinit placement (take 2) Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443D4575.1090506@mvista.com \
--to=cminyard@mvista.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@mvista.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.