* [PATCH] IPMI: fix devinit placement
@ 2006-04-12 18:05 Randy.Dunlap
2006-04-12 18:22 ` Corey Minyard
2006-04-13 5:31 ` [PATCH] IPMI: fix devinit placement (take 2) Randy.Dunlap
0 siblings, 2 replies; 3+ messages in thread
From: Randy.Dunlap @ 2006-04-12 18:05 UTC (permalink / raw)
To: lkml; +Cc: akpm, minyard
From: Randy Dunlap <rdunlap@xenotime.net>
gcc complains about __devinit in the wrong location:
drivers/char/ipmi/ipmi_si_intf.c:2205: warning: '__section__' attribute does not apply to types
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/char/ipmi/ipmi_si_intf.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2617-rc1g5.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux-2617-rc1g5/drivers/char/ipmi/ipmi_si_intf.c
@@ -2198,11 +2198,11 @@ static inline void wait_for_timer_and_th
}
}
-static struct ipmi_default_vals
+static __devinit struct ipmi_default_vals
{
int type;
int port;
-} __devinit ipmi_defaults[] =
+} ipmi_defaults[] =
{
{ .type = SI_KCS, .port = 0xca2 },
{ .type = SI_SMIC, .port = 0xca9 },
---
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] IPMI: fix devinit placement
2006-04-12 18:05 [PATCH] IPMI: fix devinit placement Randy.Dunlap
@ 2006-04-12 18:22 ` Corey Minyard
2006-04-13 5:31 ` [PATCH] IPMI: fix devinit placement (take 2) Randy.Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Corey Minyard @ 2006-04-12 18:22 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: lkml, akpm, minyard
Looks fine to me. Thanks.
-Corey
Randy.Dunlap wrote:
>From: Randy Dunlap <rdunlap@xenotime.net>
>
>gcc complains about __devinit in the wrong location:
>drivers/char/ipmi/ipmi_si_intf.c:2205: warning: '__section__' attribute does not apply to types
>
>Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>---
> drivers/char/ipmi/ipmi_si_intf.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>--- linux-2617-rc1g5.orig/drivers/char/ipmi/ipmi_si_intf.c
>+++ linux-2617-rc1g5/drivers/char/ipmi/ipmi_si_intf.c
>@@ -2198,11 +2198,11 @@ static inline void wait_for_timer_and_th
> }
> }
>
>-static struct ipmi_default_vals
>+static __devinit struct ipmi_default_vals
> {
> int type;
> int port;
>-} __devinit ipmi_defaults[] =
>+} ipmi_defaults[] =
> {
> { .type = SI_KCS, .port = 0xca2 },
> { .type = SI_SMIC, .port = 0xca9 },
>
>
>---
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] IPMI: fix devinit placement (take 2)
2006-04-12 18:05 [PATCH] IPMI: fix devinit placement Randy.Dunlap
2006-04-12 18:22 ` Corey Minyard
@ 2006-04-13 5:31 ` Randy.Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Randy.Dunlap @ 2006-04-13 5:31 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: linux-kernel, akpm, minyard
From: Randy Dunlap <rdunlap@xenotime.net>
gcc complains about __devinit in the wrong location:
drivers/char/ipmi/ipmi_si_intf.c:2205: warning: '__section__' attribute does not apply to types
Actually for data it should be __devinitdata instead of __devinit.
Otherwise it causes another gcc section mismatch error.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/char/ipmi/ipmi_si_intf.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2617-rc1g5.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux-2617-rc1g5/drivers/char/ipmi/ipmi_si_intf.c
@@ -2198,11 +2198,11 @@ static inline void wait_for_timer_and_th
}
}
-static struct ipmi_default_vals
+static __devinitdata struct ipmi_default_vals
{
int type;
int port;
-} __devinit ipmi_defaults[] =
+} ipmi_defaults[] =
{
{ .type = SI_KCS, .port = 0xca2 },
{ .type = SI_SMIC, .port = 0xca9 },
---
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-04-13 5:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-12 18:05 [PATCH] IPMI: fix devinit placement Randy.Dunlap
2006-04-12 18:22 ` Corey Minyard
2006-04-13 5:31 ` [PATCH] IPMI: fix devinit placement (take 2) Randy.Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.