RE: [PATCH][Mini-OS] cscope patch

RE: [PATCH][Mini-OS] cscope patch

[Puthiyaparambil, Aravindh]

No worries. I will resend with the correct syntax. I am using Outlook so
I am not able to inline :-) I am inserting the patch file as a
plain-text attachment. Are you not able to read it?

Aravindh


> -----Original Message-----
> From: Anthony Liguori [mailto:aliguori@us.ibm.com]
> Sent: Thursday, April 13, 2006 11:03 AM
> To: Puthiyaparambil, Aravindh
> Cc: xen-devel@lists.xensource.com; Grzegorz Milos
> Subject: Re: [Xen-devel] [PATCH][Mini-OS] cscope patch
> 
> Sorry to be a nuisance about this, but it really ought to be
> Signed-off-by.  Also, if you can send future patches as a plain-text
> attachment (or inlined) it would be much appreciated.
> 
> Regards,
> 
> Anthony Liguori
> 
> Puthiyaparambil, Aravindh wrote:
> > This patch adds a cscope option to the Mini-OS makefile.
> >
> > Signed off by Aravindh Puthiyaparambil
> > <aravindh.puthiyaparambil@unisys.com>
> >
> >
------------------------------------------------------------------------
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
> >

Re: [PATCH][Mini-OS] cscope patch

[Anthony Liguori]

Puthiyaparambil, Aravindh wrote:
> No worries. I will resend with the correct syntax. I am using Outlook so
> I am not able to inline :-) I am inserting the patch file as a
> plain-text attachment. Are you not able to read it?
>   

Yeah, it's coming across as a "application/octet-stream".  Since this is 
the MIME type for binary data, many mailers won't even attempt to 
display the contents inline making replying to portions of a patch awkward.

I'm not a Windows guy so I don't know what to recommend but I imagine 
there's a solution to this problem (perhaps Outlook doesn't recognize 
the .patch extension and therefore treats it as binary data?).

Regards,

Anthony Liguori

> Aravindh
>
>
>   
>> -----Original Message-----
>> From: Anthony Liguori [mailto:aliguori@us.ibm.com]
>> Sent: Thursday, April 13, 2006 11:03 AM
>> To: Puthiyaparambil, Aravindh
>> Cc: xen-devel@lists.xensource.com; Grzegorz Milos
>> Subject: Re: [Xen-devel] [PATCH][Mini-OS] cscope patch
>>
>> Sorry to be a nuisance about this, but it really ought to be
>> Signed-off-by.  Also, if you can send future patches as a plain-text
>> attachment (or inlined) it would be much appreciated.
>>
>> Regards,
>>
>> Anthony Liguori
>>
>> Puthiyaparambil, Aravindh wrote:
>>     
>>> This patch adds a cscope option to the Mini-OS makefile.
>>>
>>> Signed off by Aravindh Puthiyaparambil
>>> <aravindh.puthiyaparambil@unisys.com>
>>>
>>>
>>>       
> ------------------------------------------------------------------------
>   
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@lists.xensource.com
>>> http://lists.xensource.com/xen-devel
>>>
>>>       
>
>   

[PATCH][Mini-OS] cscope patch

[Puthiyaparambil, Aravindh]

[-- Attachment #1: Type: text/plain, Size: 139 bytes --]

This patch adds a cscope option to the Mini-OS makefile.

Signed off by Aravindh Puthiyaparambil
<aravindh.puthiyaparambil@unisys.com>

[-- Attachment #2: cscope.patch --]
[-- Type: application/octet-stream, Size: 768 bytes --]

diff -r 2a7a46dd3bd6 .hgignore
--- a/.hgignore	Thu Apr 13 11:26:01 2006 +0100
+++ b/.hgignore	Thu Apr 13 10:06:30 2006 -0400
@@ -52,6 +52,7 @@
 ^extras/mini-os/h/hypervisor-ifs$
 ^extras/mini-os/h/xen-public$
 ^extras/mini-os/mini-os\..*$
+^extras/mini-os/cscope\.*$
 ^install/.*$
 ^linux-[^/]*-xen/.*$
 ^linux-[^/]*-xen0/.*$
diff -r 2a7a46dd3bd6 extras/mini-os/Makefile
--- a/extras/mini-os/Makefile	Thu Apr 13 11:26:01 2006 +0100
+++ b/extras/mini-os/Makefile	Thu Apr 13 10:06:30 2006 -0400
@@ -60,4 +60,12 @@ clean:
 %.o: %.S $(HDRS) Makefile
 	$(CC) $(CFLAGS) -D__ASSEMBLY__ -c $< -o $@
 
+define all_sources
+     ( find . -follow -name SCCS -prune -o -name '*.[chS]' -print )
+endef
 
+.PHONY: cscope
+cscope:
+	$(all_sources) > cscope.files
+	cscope -k -b -q
+

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH][Mini-OS] cscope patch

[Anthony Liguori]

Sorry to be a nuisance about this, but it really ought to be 
Signed-off-by.  Also, if you can send future patches as a plain-text 
attachment (or inlined) it would be much appreciated.

Regards,

Anthony Liguori

Puthiyaparambil, Aravindh wrote:
> This patch adds a cscope option to the Mini-OS makefile.
>
> Signed off by Aravindh Puthiyaparambil
> <aravindh.puthiyaparambil@unisys.com>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>