Re: [igt-dev] [PATCH i-g-t] tests: i915_pm_rpm : Dump i915_runtime_pm_status

["Gupta, Anshuman" <anshuman.gupta@intel.com>]

> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Sent: Saturday, February 12, 2022 6:54 AM
> To: Gupta, Anshuman <anshuman.gupta@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [PATCH i-g-t] tests: i915_pm_rpm : Dump i915_runtime_pm_status
> 
> On Fri, 11 Feb 2022 08:13:14 -0800, Anshuman Gupta wrote:
> >
> > Dump i915_runtime_pm_status conditionally whenever runtime pm status
> > got active and it was expected to be suspended.
> >
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > ---
> >  tests/i915/i915_pm_rpm.c | 13 ++++++++++---
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c index
> > 648b0cffb..d1ba69af4 100644
> > --- a/tests/i915/i915_pm_rpm.c
> > +++ b/tests/i915/i915_pm_rpm.c
> > @@ -201,10 +201,17 @@ static bool wait_for_pc8_status(enum pc8_status
> > status)
> >
> >  static bool wait_for_suspended(void)
> >  {
> > -	if (has_pc8 && !has_runtime_pm)
> > +	bool suspended = false;
> 
> Nit but maybe let's move this into the else, I'll move and merge it:
> 
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Thanks Ashutosh for merging , do I need to backport it to IGT.
I see this patch is also part of internal IGT tree.
Thanks,
Anshuman Gupta.
> 
> > +
> > +	if (has_pc8 && !has_runtime_pm) {
> >		return wait_for_pc8_status(PC8_ENABLED);
> > -	else
> > -		return
> igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
> > +	} else {
> > +		suspended =
> igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
> > +		if (!suspended)
> > +			igt_debugfs_dump(drm_fd,
> "i915_runtime_pm_status");
> > +
> > +		return suspended;
> > +	}
> >  }
> >
> >  static bool wait_for_active(void)
> > --
> > 2.26.2
> >