[igt-dev] [PATCH i-g-t] tests: i915_pm_rpm : Dump i915_runtime_pm_status

[igt-dev] [PATCH i-g-t] tests: i915_pm_rpm : Dump i915_runtime_pm_status

[Anshuman Gupta]

Dump i915_runtime_pm_status conditionally whenever runtime pm status
got active and it was expected to be suspended.

Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/i915/i915_pm_rpm.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index 648b0cffb..d1ba69af4 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -201,10 +201,17 @@ static bool wait_for_pc8_status(enum pc8_status status)
 
 static bool wait_for_suspended(void)
 {
-	if (has_pc8 && !has_runtime_pm)
+	bool suspended = false;
+
+	if (has_pc8 && !has_runtime_pm) {
 		return wait_for_pc8_status(PC8_ENABLED);
-	else
-		return igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
+	} else {
+		suspended = igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
+		if (!suspended)
+			igt_debugfs_dump(drm_fd, "i915_runtime_pm_status");
+
+		return suspended;
+	}
 }
 
 static bool wait_for_active(void)
-- 
2.26.2

[igt-dev] ✗ Fi.CI.BAT: failure for tests: i915_pm_rpm : Dump i915_runtime_pm_status

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 5794 bytes --]

== Series Details ==

Series: tests: i915_pm_rpm : Dump i915_runtime_pm_status
URL   : https://patchwork.freedesktop.org/series/100038/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11219 -> IGTPW_6614
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_6614 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_6614, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/index.html

Participating hosts (48 -> 43)
------------------------------

  Additional (1): fi-pnv-d510 
  Missing    (6): shard-tglu fi-bsw-cyan bat-adlp-4 shard-rkl shard-dg1 bat-jsl-2 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_6614:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_exec_suspend@basic-s0@smem:
    - fi-kbl-soraka:      [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11219/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0@smem.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0@smem.html

  
Known issues
------------

  Here are the changes found in IGTPW_6614 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@semaphore:
    - fi-hsw-4770:        NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#109315]) +17 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-hsw-4770/igt@amdgpu/amd_basic@semaphore.html

  * igt@gem_huc_copy@huc-copy:
    - fi-skl-6600u:       NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@gem_huc_copy@huc-copy.html
    - fi-pnv-d510:        NOTRUN -> [SKIP][5] ([fdo#109271]) +57 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-pnv-d510/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@verify-random:
    - fi-skl-6600u:       NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@gem_lmem_swapping@verify-random.html

  * igt@kms_chamelium@vga-edid-read:
    - fi-skl-6600u:       NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@kms_chamelium@vga-edid-read.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-skl-6600u:       NOTRUN -> [SKIP][8] ([fdo#109271]) +2 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-cml-u2:          [PASS][9] -> [DMESG-WARN][10] ([i915#4269])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11219/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - fi-skl-6600u:       NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#533])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_psr@primary_page_flip:
    - fi-skl-6600u:       NOTRUN -> [FAIL][12] ([i915#4547])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@kms_psr@primary_page_flip.html

  * igt@runner@aborted:
    - fi-skl-6600u:       NOTRUN -> [FAIL][13] ([i915#4312])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@gem_flink_basic@bad-flink:
    - fi-skl-6600u:       [INCOMPLETE][14] ([i915#4547]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11219/fi-skl-6600u/igt@gem_flink_basic@bad-flink.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@gem_flink_basic@bad-flink.html

  * igt@i915_selftest@live@hangcheck:
    - fi-hsw-4770:        [INCOMPLETE][16] ([i915#4785]) -> [PASS][17]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11219/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6342 -> IGTPW_6614

  CI-20190529: 20190529
  CI_DRM_11219: 1129051ad132beede618ec95745886d59c14e266 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_6614: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/index.html
  IGT_6342: 1bd167a3af9e8f6168ac89c64c64b929694d9be7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/index.html

[-- Attachment #2: Type: text/html, Size: 7183 bytes --]

Re: [igt-dev] [PATCH i-g-t] tests: i915_pm_rpm : Dump i915_runtime_pm_status

[Dixit, Ashutosh]

On Fri, 11 Feb 2022 08:13:14 -0800, Anshuman Gupta wrote:
>
> Dump i915_runtime_pm_status conditionally whenever runtime pm status
> got active and it was expected to be suspended.
>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  tests/i915/i915_pm_rpm.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index 648b0cffb..d1ba69af4 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -201,10 +201,17 @@ static bool wait_for_pc8_status(enum pc8_status status)
>
>  static bool wait_for_suspended(void)
>  {
> -	if (has_pc8 && !has_runtime_pm)
> +	bool suspended = false;

Nit but maybe let's move this into the else, I'll move and merge it:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> +
> +	if (has_pc8 && !has_runtime_pm) {
>		return wait_for_pc8_status(PC8_ENABLED);
> -	else
> -		return igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
> +	} else {
> +		suspended = igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
> +		if (!suspended)
> +			igt_debugfs_dump(drm_fd, "i915_runtime_pm_status");
> +
> +		return suspended;
> +	}
>  }
>
>  static bool wait_for_active(void)
> --
> 2.26.2
>

Re: [igt-dev] [PATCH i-g-t] tests: i915_pm_rpm : Dump i915_runtime_pm_status

[Gupta, Anshuman]

> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Sent: Saturday, February 12, 2022 6:54 AM
> To: Gupta, Anshuman <anshuman.gupta@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [PATCH i-g-t] tests: i915_pm_rpm : Dump i915_runtime_pm_status
> 
> On Fri, 11 Feb 2022 08:13:14 -0800, Anshuman Gupta wrote:
> >
> > Dump i915_runtime_pm_status conditionally whenever runtime pm status
> > got active and it was expected to be suspended.
> >
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > ---
> >  tests/i915/i915_pm_rpm.c | 13 ++++++++++---
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c index
> > 648b0cffb..d1ba69af4 100644
> > --- a/tests/i915/i915_pm_rpm.c
> > +++ b/tests/i915/i915_pm_rpm.c
> > @@ -201,10 +201,17 @@ static bool wait_for_pc8_status(enum pc8_status
> > status)
> >
> >  static bool wait_for_suspended(void)
> >  {
> > -	if (has_pc8 && !has_runtime_pm)
> > +	bool suspended = false;
> 
> Nit but maybe let's move this into the else, I'll move and merge it:
> 
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Thanks Ashutosh for merging , do I need to backport it to IGT.
I see this patch is also part of internal IGT tree.
Thanks,
Anshuman Gupta.
> 
> > +
> > +	if (has_pc8 && !has_runtime_pm) {
> >		return wait_for_pc8_status(PC8_ENABLED);
> > -	else
> > -		return
> igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
> > +	} else {
> > +		suspended =
> igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
> > +		if (!suspended)
> > +			igt_debugfs_dump(drm_fd,
> "i915_runtime_pm_status");
> > +
> > +		return suspended;
> > +	}
> >  }
> >
> >  static bool wait_for_active(void)
> > --
> > 2.26.2
> >