From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
To: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
Laurent Pinchart
<laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 1/2] iommu/arm-smmu: Replace list walk with platform driver data
Date: Sun, 02 Mar 2014 18:59:27 +0100 [thread overview]
Message-ID: <4440723.cnxQ5HD11R@avalon> (raw)
In-Reply-To: <20140228163837.GC30996-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
Hi Will,
On Friday 28 February 2014 16:38:37 Will Deacon wrote:
> Hi Laurent,
>
> On Fri, Feb 28, 2014 at 03:37:09PM +0000, Laurent Pinchart wrote:
> > Instead of walking the list of registered SMMU devices at remove time to
> > locate the device being removed, set platform driver data at probe time
> > to point to the SMMU and retrieve the pointer at remove time.
>
> What does this gain us other than a slight code shrinkage?
Just a slight code shrinkage. That's better than nothing, isn't it ? :-)
> If we could get rid of the arm_smmu_devices list, then I'd be more excited
> by this change!
Associating devices with IOMMUs is something that should be performed by the
IOMMU core. I might give this a try, but I'll be busy with other tasks for the
next couple of weeks.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] iommu/arm-smmu: Replace list walk with platform driver data
Date: Sun, 02 Mar 2014 18:59:27 +0100 [thread overview]
Message-ID: <4440723.cnxQ5HD11R@avalon> (raw)
In-Reply-To: <20140228163837.GC30996@mudshark.cambridge.arm.com>
Hi Will,
On Friday 28 February 2014 16:38:37 Will Deacon wrote:
> Hi Laurent,
>
> On Fri, Feb 28, 2014 at 03:37:09PM +0000, Laurent Pinchart wrote:
> > Instead of walking the list of registered SMMU devices at remove time to
> > locate the device being removed, set platform driver data at probe time
> > to point to the SMMU and retrieve the pointer at remove time.
>
> What does this gain us other than a slight code shrinkage?
Just a slight code shrinkage. That's better than nothing, isn't it ? :-)
> If we could get rid of the arm_smmu_devices list, then I'd be more excited
> by this change!
Associating devices with IOMMUs is something that should be performed by the
IOMMU core. I might give this a try, but I'll be busy with other tasks for the
next couple of weeks.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-03-02 17:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 15:37 [PATCH 0/2] ARM SMMU fixes Laurent Pinchart
2014-02-28 15:37 ` Laurent Pinchart
[not found] ` <1393601830-4677-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2014-02-28 15:37 ` [PATCH 1/2] iommu/arm-smmu: Replace list walk with platform driver data Laurent Pinchart
2014-02-28 15:37 ` Laurent Pinchart
[not found] ` <1393601830-4677-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2014-02-28 16:38 ` Will Deacon
2014-02-28 16:38 ` Will Deacon
[not found] ` <20140228163837.GC30996-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2014-03-02 17:59 ` Laurent Pinchart [this message]
2014-03-02 17:59 ` Laurent Pinchart
2014-02-28 15:37 ` [PATCH 2/2] iommu/arm-smmu: Return 0 on unmap failure Laurent Pinchart
2014-02-28 15:37 ` Laurent Pinchart
[not found] ` <1393601830-4677-3-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2014-02-28 16:39 ` Will Deacon
2014-02-28 16:39 ` Will Deacon
2014-04-02 23:52 ` [PATCH 0/2] ARM SMMU fixes Laurent Pinchart
2014-04-02 23:52 ` Laurent Pinchart
2014-04-08 13:41 ` Laurent Pinchart
2014-04-08 13:41 ` Laurent Pinchart
2014-04-08 13:57 ` Marc Zyngier
2014-04-08 13:57 ` Marc Zyngier
[not found] ` <53440057.6020703-5wv7dgnIgG8@public.gmane.org>
2014-04-14 16:58 ` Will Deacon
2014-04-14 16:58 ` Will Deacon
[not found] ` <20140414165858.GI12916-5wv7dgnIgG8@public.gmane.org>
2014-04-15 15:55 ` Laurent Pinchart
2014-04-15 15:55 ` Laurent Pinchart
2014-04-16 14:22 ` Will Deacon
2014-04-16 14:22 ` Will Deacon
[not found] ` <20140416142206.GB2005-5wv7dgnIgG8@public.gmane.org>
2014-04-16 14:25 ` Laurent Pinchart
2014-04-16 14:25 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4440723.cnxQ5HD11R@avalon \
--to=laurent.pinchart-rylnwiuwjnjg/c1bvhzhaw@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.