All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Fabio Estevam <festevam@gmail.com>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS
Date: Thu, 13 Oct 2022 07:55:06 +0200	[thread overview]
Message-ID: <4442509.LvFx2qVVIh@steina-w> (raw)
In-Reply-To: <fe62c669-01e0-52bd-fae2-69fcbc375c23@opensource.wdc.com>

Hello Damien,

Am Donnerstag, 13. Oktober 2022, 06:20:16 CEST schrieb Damien Le Moal:
> On 10/12/22 22:30, Alexander Stein wrote:
> > Hello Fabio,
> > 
> > Am Mittwoch, 12. Oktober 2022, 15:23:04 CEST schrieb Fabio Estevam:
> >> Hi Alexander,
> >> 
> >> On Wed, Oct 12, 2022 at 10:11 AM Alexander Stein
> >> 
> >> <alexander.stein@ew.tq-group.com> wrote:
> >>> 'ahci:' is an invalid prefix, preventing the module from autoloading.
> >>> Fix this by using the 'platform:' prefix and DRV_NAME.
> >> 
> >> What about adding a Fixes tag?
> >> 
> >> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> > 
> > Thanks. A Fixes tag seems reasonable, but I have to admit I don't know at
> > which point auto loading stopped working (if it did at all).
> 
> Given that the alias was wrong in the first place when added for a
> platform driver, this I think should be a fix for:
> 
> 9e54eae23bc9 ("ahci_imx: add ahci sata support on imx platforms")

I was hesitating tagging the very first commit, not knowing if it did work at 
that time. But it seems reasonable.

> I can add the Fixes tag when applying.

Thanks!

Best regards,
Alexander



WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Fabio Estevam <festevam@gmail.com>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS
Date: Thu, 13 Oct 2022 07:55:06 +0200	[thread overview]
Message-ID: <4442509.LvFx2qVVIh@steina-w> (raw)
In-Reply-To: <fe62c669-01e0-52bd-fae2-69fcbc375c23@opensource.wdc.com>

Hello Damien,

Am Donnerstag, 13. Oktober 2022, 06:20:16 CEST schrieb Damien Le Moal:
> On 10/12/22 22:30, Alexander Stein wrote:
> > Hello Fabio,
> > 
> > Am Mittwoch, 12. Oktober 2022, 15:23:04 CEST schrieb Fabio Estevam:
> >> Hi Alexander,
> >> 
> >> On Wed, Oct 12, 2022 at 10:11 AM Alexander Stein
> >> 
> >> <alexander.stein@ew.tq-group.com> wrote:
> >>> 'ahci:' is an invalid prefix, preventing the module from autoloading.
> >>> Fix this by using the 'platform:' prefix and DRV_NAME.
> >> 
> >> What about adding a Fixes tag?
> >> 
> >> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> > 
> > Thanks. A Fixes tag seems reasonable, but I have to admit I don't know at
> > which point auto loading stopped working (if it did at all).
> 
> Given that the alias was wrong in the first place when added for a
> platform driver, this I think should be a fix for:
> 
> 9e54eae23bc9 ("ahci_imx: add ahci sata support on imx platforms")

I was hesitating tagging the very first commit, not knowing if it did work at 
that time. But it seems reasonable.

> I can add the Fixes tag when applying.

Thanks!

Best regards,
Alexander



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-10-13  5:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 13:11 [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS Alexander Stein
2022-10-12 13:11 ` Alexander Stein
2022-10-12 13:23 ` Fabio Estevam
2022-10-12 13:23   ` Fabio Estevam
2022-10-12 13:30   ` Alexander Stein
2022-10-12 13:30     ` Alexander Stein
2022-10-13  4:20     ` Damien Le Moal
2022-10-13  4:20       ` Damien Le Moal
2022-10-13  5:55       ` Alexander Stein [this message]
2022-10-13  5:55         ` Alexander Stein
2022-10-13  5:56         ` Damien Le Moal
2022-10-13  5:56           ` Damien Le Moal
2022-10-17  3:02 ` Damien Le Moal
2022-10-17  3:02   ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4442509.LvFx2qVVIh@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.