Re: [PATCH] change dom0 headers path

[Anthony Liguori <aliguori@us.ibm.com>]

Keir Fraser wrote:
>
> On 20 Apr 2006, at 14:55, Anthony Liguori wrote:
>
>> Because libxc "leaks" a few of the dom0_op structures like 
>> dom0_getvcpuinfo_t, dom0_shadow_control_stats_t, etc in its public 
>> interface.  This could be fixed by making sure all of those 
>> structures had wrapper (like xc_dominfo_t).
>
> Those are defined in Xen public header files, not in Linux's privcmd.h.

Yes, sorry, I read the first mail to quickly.  This is another of my 
gripes though (it would be nice if xenctrl.h didn't pull in the Xen 
public headers too).

About privcmd.h, the users of it are making hypercalls that aren't 
exposed through libxenctrl.  Those users probably ought to add the 
appropriate plumbing to libxenctrl.  This includes the ACM stuff, 
xenmon/xentrace, and xenstat.

Regards,

Anthony Liguori

>  -- Keir
>