* sendpage and high mem pages
@ 2006-04-20 19:29 Mike Christie
2006-04-20 19:35 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mike Christie @ 2006-04-20 19:29 UTC (permalink / raw)
To: netdev
I was wondering if it is ok to pass sendpage high mem pages. If a piece
of code does this:
struct socket *sock;
sock->ops->sendpage(pg...)
and pg is a highmem page will the network layer do the right thing or
should the caller check the page type and call sock_no_sendpage() for
highmen? It looks like net/sunrpc/xprtsock.c does a check but
drivers/scsi/iscsi_tcp.c and some others do not.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: sendpage and high mem pages
2006-04-20 19:29 sendpage and high mem pages Mike Christie
@ 2006-04-20 19:35 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2006-04-20 19:35 UTC (permalink / raw)
To: michaelc; +Cc: netdev
From: Mike Christie <michaelc@cs.wisc.edu>
Date: Thu, 20 Apr 2006 14:29:06 -0500
> I was wondering if it is ok to pass sendpage high mem pages. If a piece
> of code does this:
>
> struct socket *sock;
>
> sock->ops->sendpage(pg...)
>
> and pg is a highmem page will the network layer do the right thing or
> should the caller check the page type and call sock_no_sendpage() for
> highmen? It looks like net/sunrpc/xprtsock.c does a check but
> drivers/scsi/iscsi_tcp.c and some others do not.
TCP and others handle this just fine, if something doesn't then it
needs to be fixed. Any page in the page cache can be sent over this
interface.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-04-20 19:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-20 19:29 sendpage and high mem pages Mike Christie
2006-04-20 19:35 ` David S. Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.