From: Jes Sorensen <jes@sgi.com>
To: Robin Holt <holt@sgi.com>
Cc: Dean Nelson <dcn@sgi.com>, Andrew Morton <akpm@osdl.org>,
tony.luck@intel.com, avolkov@varma-el.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
paulus@samba.org
Subject: Re: [PATCH] change gen_pool allocator to not touch managed memory
Date: Wed, 26 Apr 2006 11:18:30 +0000 [thread overview]
Message-ID: <444F5706.4030805@sgi.com> (raw)
In-Reply-To: <20060426110856.GB19935@lnx-holt.americas.sgi.com>
Robin Holt wrote:
> On Wed, Apr 26, 2006 at 11:12:48AM +0200, Jes Sorensen wrote:
>>> - if (status)
>>> - printk(KERN_WARNING "smp_call_function failed for "
>>> - "uncached_ipi_mc_drain! (%i)\n", status);
>>> + (void) smp_call_function(uncached_ipi_mc_drain, NULL, 0, 1);
>> This thing could in theory fail so having the error check there seems
>> the right thing to me. In either case, please don't (void) the function
>> return (this is a style issue, I know).
>
> I must be blind. Both up and smp cases for smp_call_function appear to
> always return 0. What am I missing?
Not on all architectures, at least PPC can return != 0 - dunno if this
is a realistic case though. If not, maybe the prototype for
smp_call_function() ought to be changed.
Cheers,
Jes
WARNING: multiple messages have this Message-ID (diff)
From: Jes Sorensen <jes@sgi.com>
To: Robin Holt <holt@sgi.com>
Cc: Dean Nelson <dcn@sgi.com>, Andrew Morton <akpm@osdl.org>,
tony.luck@intel.com, avolkov@varma-el.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
paulus@samba.org
Subject: Re: [PATCH] change gen_pool allocator to not touch managed memory
Date: Wed, 26 Apr 2006 13:18:30 +0200 [thread overview]
Message-ID: <444F5706.4030805@sgi.com> (raw)
In-Reply-To: <20060426110856.GB19935@lnx-holt.americas.sgi.com>
Robin Holt wrote:
> On Wed, Apr 26, 2006 at 11:12:48AM +0200, Jes Sorensen wrote:
>>> - if (status)
>>> - printk(KERN_WARNING "smp_call_function failed for "
>>> - "uncached_ipi_mc_drain! (%i)\n", status);
>>> + (void) smp_call_function(uncached_ipi_mc_drain, NULL, 0, 1);
>> This thing could in theory fail so having the error check there seems
>> the right thing to me. In either case, please don't (void) the function
>> return (this is a style issue, I know).
>
> I must be blind. Both up and smp cases for smp_call_function appear to
> always return 0. What am I missing?
Not on all architectures, at least PPC can return != 0 - dunno if this
is a realistic case though. If not, maybe the prototype for
smp_call_function() ought to be changed.
Cheers,
Jes
next prev parent reply other threads:[~2006-04-26 11:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 18:35 [PATCH] change gen_pool allocator to not touch managed memory Dean Nelson
2006-04-24 18:35 ` Dean Nelson
2006-04-25 1:16 ` Andrew Morton
2006-04-25 1:16 ` Andrew Morton
2006-04-25 15:50 ` Dean Nelson
2006-04-25 15:50 ` Dean Nelson
2006-04-26 9:12 ` Jes Sorensen
2006-04-26 9:12 ` Jes Sorensen
2006-04-26 11:08 ` Robin Holt
2006-04-26 11:08 ` Robin Holt
2006-04-26 11:18 ` Jes Sorensen [this message]
2006-04-26 11:18 ` Jes Sorensen
2006-04-26 13:28 ` Dean Nelson
2006-04-26 13:28 ` Dean Nelson
2006-04-26 13:42 ` Jes Sorensen
2006-04-26 13:42 ` Jes Sorensen
2006-04-26 16:31 ` Dean Nelson
2006-04-26 16:31 ` Dean Nelson
2006-04-28 12:49 ` Jes Sorensen
2006-04-28 12:49 ` Jes Sorensen
2006-04-26 10:27 ` Jesper Juhl
2006-04-26 10:27 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444F5706.4030805@sgi.com \
--to=jes@sgi.com \
--cc=akpm@osdl.org \
--cc=avolkov@varma-el.com \
--cc=dcn@sgi.com \
--cc=holt@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.