All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Jens Axboe <axboe@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
	torvalds@osdl.org, linux-kernel@vger.kernel.org, npiggin@suse.de,
	linux-mm@kvack.org
Subject: Re: Lockless page cache test results
Date: Thu, 27 Apr 2006 23:36:06 +1000	[thread overview]
Message-ID: <4450C8C6.9040309@yahoo.com.au> (raw)
In-Reply-To: <20060427090000.GA23137@suse.de>

Jens Axboe wrote:
> On Thu, Apr 27 2006, Nick Piggin wrote:

>>Hmm, what's more, find_get_pages_contig shouldn't result in any
>>fewer tree_lock acquires than the open coded thing there now
>>(for the densely populated pagecache case).
> 
> 
> How do you figure? The open coded one does a find_get_page() on each
> page in that range, so for x number of pages we'll grab and release
> ->tree_lock x times.

Yeah you're right. I had in mind that you were using
find_get_pages_contig in readahead, rather than in splice.

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Jens Axboe <axboe@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
	torvalds@osdl.org, linux-kernel@vger.kernel.org, npiggin@suse.de,
	linux-mm@kvack.org
Subject: Re: Lockless page cache test results
Date: Thu, 27 Apr 2006 23:36:06 +1000	[thread overview]
Message-ID: <4450C8C6.9040309@yahoo.com.au> (raw)
In-Reply-To: <20060427090000.GA23137@suse.de>

Jens Axboe wrote:
> On Thu, Apr 27 2006, Nick Piggin wrote:

>>Hmm, what's more, find_get_pages_contig shouldn't result in any
>>fewer tree_lock acquires than the open coded thing there now
>>(for the densely populated pagecache case).
> 
> 
> How do you figure? The open coded one does a find_get_page() on each
> page in that range, so for x number of pages we'll grab and release
> ->tree_lock x times.

Yeah you're right. I had in mind that you were using
find_get_pages_contig in readahead, rather than in splice.

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-04-27 15:17 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-26 13:53 Lockless page cache test results Jens Axboe
2006-04-26 14:43 ` Nick Piggin
2006-04-26 14:43   ` Nick Piggin
2006-04-26 19:46   ` Jens Axboe
2006-04-26 19:46     ` Jens Axboe
2006-04-27  5:39     ` Chen, Kenneth W
2006-04-27  5:39       ` Chen, Kenneth W
2006-04-27  6:07       ` Nick Piggin
2006-04-27  6:07         ` Nick Piggin
2006-04-27  6:15       ` Andi Kleen
2006-04-27  6:15         ` Andi Kleen
2006-04-27  7:51         ` Chen, Kenneth W
2006-04-27  7:51           ` Chen, Kenneth W
2006-04-26 16:55 ` Andrew Morton
2006-04-26 16:55   ` Andrew Morton
2006-04-26 17:42   ` Jens Axboe
2006-04-26 17:42     ` Jens Axboe
2006-04-26 18:10     ` Andrew Morton
2006-04-26 18:10       ` Andrew Morton
2006-04-26 18:23       ` Jens Axboe
2006-04-26 18:23         ` Jens Axboe
2006-04-26 18:46         ` Andrew Morton
2006-04-26 18:46           ` Andrew Morton
2006-04-26 19:21           ` Jens Axboe
2006-04-26 19:21             ` Jens Axboe
2006-04-27  5:58           ` Nick Piggin
2006-04-27  5:58             ` Nick Piggin
2006-04-26 18:34       ` Christoph Lameter
2006-04-26 18:34         ` Christoph Lameter
2006-04-26 18:47         ` Andrew Morton
2006-04-26 18:47           ` Andrew Morton
2006-04-26 18:48           ` Christoph Lameter
2006-04-26 18:48             ` Christoph Lameter
2006-04-26 18:49           ` Jens Axboe
2006-04-26 18:49             ` Jens Axboe
2006-04-26 20:31             ` Christoph Lameter
2006-04-26 20:31               ` Christoph Lameter
2006-04-28 14:01               ` David Chinner
2006-04-28 14:01                 ` David Chinner
2006-04-28 14:10                 ` David Chinner
2006-04-28 14:10                   ` David Chinner
2006-04-30  9:49                 ` Nick Piggin
2006-04-30 11:20                   ` Nick Piggin
2006-04-30 11:20                     ` Nick Piggin
2006-04-30 11:39                   ` Jens Axboe
2006-04-30 11:39                     ` Jens Axboe
2006-04-30 11:44                     ` Nick Piggin
2006-04-26 18:58       ` Christoph Hellwig
2006-04-26 18:58         ` Christoph Hellwig
2006-04-26 19:02         ` Jens Axboe
2006-04-26 19:02           ` Jens Axboe
2006-04-26 19:00       ` Linus Torvalds
2006-04-26 19:00         ` Linus Torvalds
2006-04-26 19:15         ` Jens Axboe
2006-04-26 19:15           ` Jens Axboe
2006-04-26 20:12           ` Andrew Morton
2006-04-26 20:12             ` Andrew Morton
2006-04-27  7:45             ` Jens Axboe
2006-04-27  7:47               ` Jens Axboe
2006-04-27  7:47                 ` Jens Axboe
2006-04-27  7:57               ` Nick Piggin
2006-04-27  7:57                 ` Nick Piggin
2006-04-27  8:02                 ` Nick Piggin
2006-04-27  8:02                   ` Nick Piggin
2006-04-27  9:00                   ` Jens Axboe
2006-04-27  9:00                     ` Jens Axboe
2006-04-27 13:36                     ` Nick Piggin [this message]
2006-04-27 13:36                       ` Nick Piggin
2006-04-27  8:36                 ` Jens Axboe
2006-04-27  8:36                   ` Jens Axboe
2006-04-28 11:28             ` Wu Fengguang
2006-04-28 11:28               ` Wu Fengguang
2006-04-28 11:28                 ` Wu Fengguang
2006-04-27  5:49         ` Nick Piggin
2006-04-27  5:49           ` Nick Piggin
2006-04-27 15:12           ` Linus Torvalds
2006-04-27 15:12             ` Linus Torvalds
2006-04-28  4:54             ` Nick Piggin
2006-04-28  4:54               ` Nick Piggin
2006-04-28  5:34               ` Linus Torvalds
2006-04-28  5:34                 ` Linus Torvalds
2006-04-27  9:35         ` Jens Axboe
2006-04-27  5:22       ` Nick Piggin
2006-04-27  5:22         ` Nick Piggin
2006-04-26 18:57     ` Jens Axboe
2006-04-27  2:19       ` KAMEZAWA Hiroyuki
2006-04-27  2:19         ` KAMEZAWA Hiroyuki
2006-04-27  8:03         ` Jens Axboe
2006-04-27  8:03           ` Jens Axboe
2006-04-27 11:16           ` Jens Axboe
2006-04-27 11:16             ` Jens Axboe
2006-04-27 11:41             ` KAMEZAWA Hiroyuki
2006-04-27 11:41               ` KAMEZAWA Hiroyuki
2006-04-27 11:45               ` Jens Axboe
2006-04-27 11:45                 ` Jens Axboe
2006-04-28  9:10 ` Pavel Machek
2006-04-28  9:10   ` Pavel Machek
2006-04-28  9:21   ` Jens Axboe
2006-04-28  9:21     ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2006-04-28 16:58 Al Boldi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4450C8C6.9040309@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.