[Xenomai-core] UVM build error in todays head of SVN

[Xenomai-core] UVM build error in todays head of SVN

[Wolfgang Grandegger]

Hello,

I just checked out Xenomai and realized the UVM build error below (while 
building for PPC 405 with IPIPE tracer).  "xnlock_put/get" seems not to 
be dummy without SMP.

Wolfgang.


if ppc-linux-gcc -DHAVE_CONFIG_H -I. -I. -I../../../../src/include  -O2 
-D_GNU_SOURCE -D_REENTRANT -D__XENO__ -Wall -pipe -D__IN_XENO__ 
-Wstrict-prototypes -I../../../../include -D__XENO_UVM__    -MT pod.o 
-MD -MP -MF ".deps/pod.Tpo" -c -o pod.o pod.c; \
then mv -f ".deps/pod.Tpo" ".deps/pod.Po"; else rm -f ".deps/pod.Tpo"; 
exit 1; fi
pod.c: In function 'xnpod_announce_tick':
pod.c:3304: warning: implicit declaration of function 'xnlock_get'
pod.c:3304: error: 'nklock' undeclared (first use in this function)
pod.c:3304: error: (Each undeclared identifier is reported only once
pod.c:3304: error: for each function it appears in.)
pod.c:3365: warning: implicit declaration of function 'xnlock_put'
make[4]: *** [pod.o] Error 1
make[4]: Leaving directory 
`/.automount/castor-vlab/root/home/wolf/rt/xenomai/src/skins/uvm/nucleus'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory 
`/.automount/castor-vlab/root/home/wolf/rt/xenomai/src/skins/uvm'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory 
`/.automount/castor-vlab/root/home/wolf/rt/xenomai/src/skins'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory 
`/.automount/castor-vlab/root/home/wolf/rt/xenomai/src'
make: *** [all-recursive] Error 1

Re: [Xenomai-core] UVM build error in todays head of SVN

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

Wolfgang Grandegger wrote:
> Hello,
> 
> I just checked out Xenomai and realized the UVM build error below (while
> building for PPC 405 with IPIPE tracer).  "xnlock_put/get" seems not to
> be dummy without SMP.
> 
> Wolfgang.
> 

Try this patch. It fixes the problem and also appears to me as the
correct way to solve it (UVM is a UP-machine, spinlocks are void).

Jan


--- include/asm-uvm/system.h    (Revision 1022)
+++ include/asm-uvm/system.h    (Arbeitskopie)
@@ -67,6 +67,8 @@ typedef unsigned long xnlock_t;
 #define XNARCH_LOCK_UNLOCKED 0

 #define xnlock_init(lock)              do { } while(0)
+#define xnlock_get(lock)               do { } while(0)
+#define xnlock_put(lock)               do { } while(0)
 #define xnlock_get_irqsave(lock,x)     ((x) = xnarch_lock_irq())
 #define xnlock_put_irqrestore(lock,x)  xnarch_unlock_irq(x)
 #define xnlock_clear_irqoff(lock)      xnarch_lock_irq()



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

Re: [Xenomai-core] UVM build error in todays head of SVN

[Philippe Gerum]

Jan Kiszka wrote:
> Wolfgang Grandegger wrote:
> 
>>Hello,
>>
>>I just checked out Xenomai and realized the UVM build error below (while
>>building for PPC 405 with IPIPE tracer).  "xnlock_put/get" seems not to
>>be dummy without SMP.
>>
>>Wolfgang.
>>
> 
> 
> Try this patch. It fixes the problem and also appears to me as the
> correct way to solve it (UVM is a UP-machine, spinlocks are void).
> 
> Jan
> 
> 
> --- include/asm-uvm/system.h    (Revision 1022)
> +++ include/asm-uvm/system.h    (Arbeitskopie)
> @@ -67,6 +67,8 @@ typedef unsigned long xnlock_t;
>  #define XNARCH_LOCK_UNLOCKED 0
> 
>  #define xnlock_init(lock)              do { } while(0)
> +#define xnlock_get(lock)               do { } while(0)
> +#define xnlock_put(lock)               do { } while(0)
>  #define xnlock_get_irqsave(lock,x)     ((x) = xnarch_lock_irq())
>  #define xnlock_put_irqrestore(lock,x)  xnarch_unlock_irq(x)
>  #define xnlock_clear_irqoff(lock)      xnarch_lock_irq()
> 
> 

Fixed, thanks.

-- 

Philippe.