From: Richard Weinberger <richard@nod.at>
To: hch <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Richard Henderson <richard.henderson@linaro.org>,
Matt Turner <mattst88@gmail.com>,
Magnus Lindholm <linmag7@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
will <will@kernel.org>, Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>, davem <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
anton ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
Thomas Gleixner <tglx@kernel.org>, mingo <mingo@redhat.com>,
bp <bp@alien8.de>, dave hansen <dave.hansen@linux.intel.com>,
x86 <x86@kernel.org>, hpa <hpa@zytor.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
dan j williams <dan.j.williams@intel.com>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Arnd Bergmann <arnd@arndb.de>, Song Liu <song@kernel.org>,
Yu Kuai <yukuai@fnnas.com>, Li Nan <linan122@huawei.com>,
linux-alpha <linux-alpha@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
loongarch <loongarch@lists.linux.dev>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-s390 <linux-s390@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
linux-um <linux-um@lists.infradead.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE
Date: Thu, 26 Feb 2026 22:45:26 +0100 (CET) [thread overview]
Message-ID: <445921547.2198.1772142326749.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20260226151106.144735-4-hch@lst.de>
----- Ursprüngliche Mail -----
> Von: "hch" <hch@lst.de>
> XOR_SELECT_TEMPLATE is only ever called with a NULL argument, so all the
> ifdef'ery doesn't do anything. With our without this, the time travel
> mode should work fine on CPUs that support AVX2, as the AVX2
> implementation is forced in this case, and won't work otherwise.
IIRC Johannes added XOR_SELECT_TEMPLATE() here to skip
the template selection logic because it didn't work with time travel mode.
Johannes, can you please test whether this change does not break
time travel mode?
Thanks,
//richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: hch <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Richard Henderson <richard.henderson@linaro.org>,
Matt Turner <mattst88@gmail.com>,
Magnus Lindholm <linmag7@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
will <will@kernel.org>, Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>, davem <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
anton ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
Thomas Gleixner <tglx@kernel.org>, mingo <mingo@redhat.com>,
bp <bp@alien8.de>, dave hansen <dave.hansen@linux.intel.com>,
x86 <x86@kernel.org>, hpa <hpa@zytor.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
dan j williams <dan.j.williams@intel.com>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Arnd Bergmann <arnd@arndb.de>, Song Liu <song@kernel.org>,
Yu Kuai <yukuai@fnnas.com>, Li Nan <linan122@huawei.com>,
linux-alpha <linux-alpha@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
loongarch <loongarch@lists.linux.dev>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-s390 <linux-s390@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
linux-um <linux-um@lists.infradead.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE
Date: Thu, 26 Feb 2026 22:45:26 +0100 (CET) [thread overview]
Message-ID: <445921547.2198.1772142326749.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20260226151106.144735-4-hch@lst.de>
----- Ursprüngliche Mail -----
> Von: "hch" <hch@lst.de>
> XOR_SELECT_TEMPLATE is only ever called with a NULL argument, so all the
> ifdef'ery doesn't do anything. With our without this, the time travel
> mode should work fine on CPUs that support AVX2, as the AVX2
> implementation is forced in this case, and won't work otherwise.
IIRC Johannes added XOR_SELECT_TEMPLATE() here to skip
the template selection logic because it didn't work with time travel mode.
Johannes, can you please test whether this change does not break
time travel mode?
Thanks,
//richard
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-02-26 21:45 UTC|newest]
Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 15:10 cleanup the RAID5 XOR library Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 01/25] xor: assert that xor_blocks is not called from interrupt context Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-27 14:24 ` Peter Zijlstra
2026-02-27 14:24 ` Peter Zijlstra
2026-03-03 16:00 ` Christoph Hellwig
2026-03-03 16:00 ` Christoph Hellwig
2026-03-03 19:55 ` Eric Biggers
2026-03-03 19:55 ` Eric Biggers
2026-03-04 14:51 ` Christoph Hellwig
2026-03-04 14:51 ` Christoph Hellwig
2026-03-04 15:15 ` Peter Zijlstra
2026-03-04 15:15 ` Peter Zijlstra
2026-03-04 15:42 ` Christoph Hellwig
2026-03-04 15:42 ` Christoph Hellwig
2026-03-04 15:01 ` Heiko Carstens
2026-03-04 15:01 ` Heiko Carstens
2026-03-04 15:06 ` Christoph Hellwig
2026-03-04 15:06 ` Christoph Hellwig
2026-03-04 15:08 ` Heiko Carstens
2026-03-04 15:08 ` Heiko Carstens
2026-02-26 15:10 ` [PATCH 02/25] arm/xor: remove in_interrupt() handling Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 21:45 ` Richard Weinberger [this message]
2026-02-26 21:45 ` Richard Weinberger
2026-02-26 22:00 ` hch
2026-02-26 22:00 ` hch
2026-02-27 7:39 ` Johannes Berg
2026-02-27 7:39 ` Johannes Berg
2026-02-28 4:30 ` Eric Biggers
2026-02-28 4:30 ` Eric Biggers
2026-03-02 7:38 ` Johannes Berg
2026-03-02 7:38 ` Johannes Berg
2026-02-26 15:10 ` [PATCH 04/25] xor: move to lib/raid/ Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-28 4:35 ` Eric Biggers
2026-02-28 4:35 ` Eric Biggers
2026-03-03 16:01 ` Christoph Hellwig
2026-03-03 16:01 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 05/25] xor: small cleanups Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 06/25] xor: cleanup registration and probing Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-28 4:41 ` Eric Biggers
2026-02-28 4:41 ` Eric Biggers
2026-02-26 15:10 ` [PATCH 07/25] xor: split xor.h Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-28 4:43 ` Eric Biggers
2026-02-28 4:43 ` Eric Biggers
2026-03-03 16:03 ` Christoph Hellwig
2026-03-03 16:03 ` Christoph Hellwig
2026-03-03 16:15 ` Christoph Hellwig
2026-03-03 16:15 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 08/25] xor: remove macro abuse for XOR implementation registrations Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 09/25] xor: move generic implementations out of asm-generic/xor.h Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 15:40 ` Arnd Bergmann
2026-02-26 15:40 ` Arnd Bergmann
2026-02-28 7:15 ` Eric Biggers
2026-02-28 7:15 ` Eric Biggers
2026-03-03 16:09 ` Christoph Hellwig
2026-03-03 16:09 ` Christoph Hellwig
2026-03-10 14:00 ` Christoph Hellwig
2026-03-10 14:00 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 10/25] alpha: move the XOR code to lib/raid/ Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 11/25] arm: " Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 12/25] arm64: " Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 13/25] loongarch: " Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 14/25] powerpc: " Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 15/25] riscv: " Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-28 5:37 ` Eric Biggers
2026-02-28 5:37 ` Eric Biggers
2026-02-26 15:10 ` [PATCH 16/25] sparc: " Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-28 5:47 ` Eric Biggers
2026-02-28 5:47 ` Eric Biggers
2026-03-03 16:04 ` Christoph Hellwig
2026-03-03 16:04 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 17/25] s390: " Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-27 9:09 ` Heiko Carstens
2026-02-27 9:09 ` Heiko Carstens
2026-02-27 14:13 ` Christoph Hellwig
2026-02-27 14:13 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 18/25] x86: " Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-27 14:30 ` Peter Zijlstra
2026-02-27 14:30 ` Peter Zijlstra
2026-02-27 23:55 ` Eric Biggers
2026-02-27 23:55 ` Eric Biggers
2026-02-28 10:31 ` Peter Zijlstra
2026-02-28 10:31 ` Peter Zijlstra
2026-03-03 16:05 ` Christoph Hellwig
2026-03-03 16:05 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 19/25] xor: avoid indirect calls for arm64-optimized ops Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 20/25] xor: make xor.ko self-contained in lib/raid/ Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-28 6:42 ` Eric Biggers
2026-02-28 6:42 ` Eric Biggers
2026-03-03 16:06 ` Christoph Hellwig
2026-03-03 16:06 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 21/25] xor: add a better public API Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-28 6:50 ` Eric Biggers
2026-02-28 6:50 ` Eric Biggers
2026-03-03 16:07 ` Christoph Hellwig
2026-03-03 16:07 ` Christoph Hellwig
2026-03-10 6:58 ` Christoph Hellwig
2026-03-10 6:58 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 22/25] async_xor: use xor_gen Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-28 6:55 ` Eric Biggers
2026-02-28 6:55 ` Eric Biggers
2026-02-26 15:10 ` [PATCH 23/25] btrfs: " Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 24/25] xor: pass the entire operation to the low-level ops Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-28 6:58 ` Eric Biggers
2026-02-28 6:58 ` Eric Biggers
2026-03-03 16:09 ` Christoph Hellwig
2026-03-03 16:09 ` Christoph Hellwig
2026-02-26 15:10 ` [PATCH 25/25] xor: use static_call for xor_gen Christoph Hellwig
2026-02-26 15:10 ` Christoph Hellwig
2026-02-27 14:36 ` Peter Zijlstra
2026-02-27 14:36 ` Peter Zijlstra
2026-02-26 18:20 ` cleanup the RAID5 XOR library Andrew Morton
2026-02-26 18:20 ` Andrew Morton
2026-02-28 7:35 ` Eric Biggers
2026-02-28 7:35 ` Eric Biggers
2026-03-03 16:11 ` Christoph Hellwig
2026-03-03 16:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445921547.2198.1772142326749.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=andreas@gaisler.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chleroy@kernel.org \
--cc=clm@fb.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dsterba@suse.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=johannes@sipsolutions.net \
--cc=kernel@xen0n.name \
--cc=linan122@huawei.com \
--cc=linmag7@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=richard.henderson@linaro.org \
--cc=song@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.