From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Hua Zhong <hzhong@gmail.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org, linux-mm@kvack.org
Subject: Re: [PATCH] fix can_share_swap_page() when !CONFIG_SWAP
Date: Tue, 09 May 2006 11:59:39 +1000 [thread overview]
Message-ID: <445FF78B.9060803@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0605081335030.7003@blonde.wat.veritas.com>
Hugh Dickins wrote:
>On Mon, 8 May 2006, Nick Piggin wrote:
>
>>Looks like a good patch, nice catch. You should run it past Hugh but tend to
>>agree it would be nice to reuse the out of line can_share_swap_page, which
>>would fold beautifully with PageSwapCache a constant 0.
>>
>
>True; but I think Hua's patch is good as is for now, to fix
>that inefficiency. I do agree (as you know) that there's scope for
>cleanup there, and that that function is badly named; but I'm still
>unprepared to embark on the cleanup, so let's just get the fix in.
>
Sure. Queue it up for 2.6.18?
--
Send instant messages to your online friends http://au.messenger.yahoo.com
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Hua Zhong <hzhong@gmail.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org, linux-mm@kvack.org
Subject: Re: [PATCH] fix can_share_swap_page() when !CONFIG_SWAP
Date: Tue, 09 May 2006 11:59:39 +1000 [thread overview]
Message-ID: <445FF78B.9060803@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0605081335030.7003@blonde.wat.veritas.com>
Hugh Dickins wrote:
>On Mon, 8 May 2006, Nick Piggin wrote:
>
>>Looks like a good patch, nice catch. You should run it past Hugh but tend to
>>agree it would be nice to reuse the out of line can_share_swap_page, which
>>would fold beautifully with PageSwapCache a constant 0.
>>
>
>True; but I think Hua's patch is good as is for now, to fix
>that inefficiency. I do agree (as you know) that there's scope for
>cleanup there, and that that function is badly named; but I'm still
>unprepared to embark on the cleanup, so let's just get the fix in.
>
Sure. Queue it up for 2.6.18?
--
Send instant messages to your online friends http://au.messenger.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-05-09 1:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-08 1:17 [PATCH] fix can_share_swap_page() when !CONFIG_SWAP Hua Zhong
2006-05-08 1:17 ` Hua Zhong
2006-05-08 5:18 ` Nick Piggin
2006-05-08 5:18 ` Nick Piggin
2006-05-08 12:45 ` Hugh Dickins
2006-05-08 12:45 ` Hugh Dickins
2006-05-09 1:59 ` Nick Piggin [this message]
2006-05-09 1:59 ` Nick Piggin
2006-05-09 11:25 ` Hugh Dickins
2006-05-09 11:25 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445FF78B.9060803@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=hzhong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.