From: "Jan Beulich" <jbeulich@novell.com>
To: "Andrew Morton" <akpm@osdl.org>
Cc: <kristen.c.accardi@intel.com>,
<pcihpd-discuss@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Pcihpd-discuss] [PATCH] correct pciehp init recovery
Date: Tue, 09 May 2006 10:29:27 +0200 [thread overview]
Message-ID: <44606F07.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20060509004958.28b2b243.akpm@osdl.org>
>>> Andrew Morton <akpm@osdl.org> 09.05.06 09:49 >>>
>"Jan Beulich" <jbeulich@novell.com> wrote:
>>
>> >>> Kristen Accardi <kristen.c.accardi@intel.com> 28.04.06 19:38 >>>
>> >On Fri, 2006-04-28 at 16:59 +0200, Jan Beulich wrote:
>> >> Clean up the recovery path from errors during pcie_init().
>> >>
>> >It's possible that this driver never actually requested an irq if was in
>> >poll mode. Then you will call free_irq, when what you really want to do
>> >is kill the timer that may have been started.
>>
>> Thanks for pointing this out, here's the updated patch:
>>
>> Clean up the recovery path from errors during pcie_init().
>>
>
>Well, it does more than clean things up. It fixes bugs.
>
>Could we have a more accurate and complete changelog please?
Clean up (fix) the recovery path from errors during pcie_init() by properly
undoing any initialization steps already carried out.
prev parent reply other threads:[~2006-05-09 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 14:59 [PATCH] correct pciehp init recovery Jan Beulich
2006-04-28 17:38 ` [Pcihpd-discuss] " Kristen Accardi
2006-05-02 10:32 ` Jan Beulich
2006-05-09 7:49 ` Andrew Morton
2006-05-09 8:29 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44606F07.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=akpm@osdl.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.