[Xenomai-core] [BUG] kernel oops on registry duplicate names

[Xenomai-core] [BUG] kernel oops on registry duplicate names

[Ignacio García Pérez]

The subject pretty much explains it all.

Just try to create a task named "foo" and a queue also named "foo".

Tested in 2.1.1 and svn HEAD.

Nacho.

[Xenomai-core] Re: [BUG] kernel oops on registry duplicate names

[Philippe Gerum]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Ignacio García Pérez wrote:
> The subject pretty much explains it all.
> 
> Just try to create a task named "foo" and a queue also named "foo".
> 
> Tested in 2.1.1 and svn HEAD.
> 

I can't reproduce it with the attached simple test. rt_queue_create() 
returns -EEXIST as expected. Do you have any test frag to reproduce it?

-- 

Philippe.

[-- Attachment #2: dup.c --]
[-- Type: text/x-csrc, Size: 734 bytes --]

#include <sys/types.h>
#include <sys/mman.h>
#include <string.h>
#include <stdlib.h>
#include <fcntl.h>
#include <stdio.h>
#include <unistd.h>
#include <native/task.h>
#include <native/queue.h>

RT_TASK task;

RT_QUEUE q;

void queuer (void *x)

{
    int err;

    err = rt_queue_create(&q,"foo",16*1024,Q_UNLIMITED,Q_FIFO);
    printf("rt_queue_create() = %d, mapaddr=%p, mapsize=%u\n",err,q.mapbase,q.mapsize);
    err = rt_queue_delete(&q);
    printf("rt_queue_delete() = %d, mapaddr=%p, mapsize=%u\n",err,q.mapbase,q.mapsize);
}

int main (int argc, char **argv)

{
    mlockall(MCL_FUTURE|MCL_CURRENT);
    rt_task_create(&task,"foo",0,2,T_FPU);
    rt_task_start(&task,&queuer,(void *)(argc > 1));
    pause();
    exit(0);
}

[Xenomai-core] Re: [BUG] kernel oops on registry duplicate names

[Philippe Gerum]

Ignacio García Pérez wrote:
> The subject pretty much explains it all.
> 
> Just try to create a task named "foo" and a queue also named "foo".
> 
> Tested in 2.1.1 and svn HEAD.
> 

Ok, that's the other way around, you first create the queue, then the 
task, and the error path of the task creation routine seems to go wild 
afterwards when it detects the registry error.

-- 

Philippe.

Re: [Xenomai-core] Re: [BUG] kernel oops on registry duplicate names

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

Philippe Gerum wrote:
> Ignacio García Pérez wrote:
>> The subject pretty much explains it all.
>>
>> Just try to create a task named "foo" and a queue also named "foo".
>>
>> Tested in 2.1.1 and svn HEAD.
>>
> 
> Ok, that's the other way around, you first create the queue, then the
> task, and the error path of the task creation routine seems to go wild
> afterwards when it detects the registry error.
> 

That's obviously the same issue I reported a few days ago about creating
two tasks with identical names.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

Re: [Xenomai-core] Re: [BUG] kernel oops on registry duplicate names

[Philippe Gerum]

Jan Kiszka wrote:
> Philippe Gerum wrote:
> 
>>Ignacio García Pérez wrote:
>>
>>>The subject pretty much explains it all.
>>>
>>>Just try to create a task named "foo" and a queue also named "foo".
>>>
>>>Tested in 2.1.1 and svn HEAD.
>>>
>>
>>Ok, that's the other way around, you first create the queue, then the
>>task, and the error path of the task creation routine seems to go wild
>>afterwards when it detects the registry error.
>>
> 
> 
> That's obviously the same issue I reported a few days ago about creating
> two tasks with identical names.
> 

This went unnoticed from me. Could you resend this? TIA,

-- 

Philippe.

Re: [Xenomai-core] Re: [BUG] kernel oops on registry duplicate names

[Philippe Gerum]

Jan Kiszka wrote:
> Philippe Gerum wrote:
> 
>>Ignacio García Pérez wrote:
>>
>>>The subject pretty much explains it all.
>>>
>>>Just try to create a task named "foo" and a queue also named "foo".
>>>
>>>Tested in 2.1.1 and svn HEAD.
>>>
>>
>>Ok, that's the other way around, you first create the queue, then the
>>task, and the error path of the task creation routine seems to go wild
>>afterwards when it detects the registry error.
>>
> 
> 
> That's obviously the same issue I reported a few days ago about creating
> two tasks with identical names.
> 

Fixed by commits #1084 and #1085 in both branches.

-- 

Philippe.