From: Patrick McHardy <kaber@trash.net>
To: Philip Craig <philipc@snapgear.com>
Cc: Harald Welte <laforge@netfilter.org>,
netfilter-devel@lists.netfilter.org
Subject: Re: ulogd2 and nflog prefix
Date: Mon, 15 May 2006 07:36:06 +0200 [thread overview]
Message-ID: <44681346.3000301@trash.net> (raw)
In-Reply-To: <4467EC50.3030907@snapgear.com>
Philip Craig wrote:
> The log message prefix contained in the netlink message is
> not null terminated, but nflog_get_prefix() returns a pointer
> to the data in the netlink message, and ulogd2 treats it as
> null terminated.
>
> I can create a patch to fix this if I know how it is meant to work:
> - null terminate in kernel?
> - nflog_get_prefix() should copy and null terminate?
> - add nflog_get_prefix_len() and handle in ulogd?
Most other netlink users in the kernel dealing with strings use
rtattr_strlcpy these days, which automatically terminates strings.
I think we should do the same for consistency.
next prev parent reply other threads:[~2006-05-15 5:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-15 2:49 ulogd2 and nflog prefix Philip Craig
2006-05-15 5:36 ` Patrick McHardy [this message]
2006-05-15 6:59 ` Philip Craig
2006-05-15 7:06 ` Patrick McHardy
2006-05-15 7:33 ` Philip Craig
2006-05-15 7:39 ` Patrick McHardy
2006-05-15 7:59 ` Philip Craig
2006-05-15 8:31 ` Patrick McHardy
2006-05-15 9:35 ` Harald Welte
2006-05-15 9:41 ` Patrick McHardy
2006-05-15 9:05 ` Philip Craig
2006-05-15 9:10 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44681346.3000301@trash.net \
--to=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=philipc@snapgear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.