From: Patrick McHardy <kaber@trash.net>
To: Philip Craig <philipc@snapgear.com>
Cc: Harald Welte <laforge@netfilter.org>,
netfilter-devel@lists.netfilter.org
Subject: Re: ulogd2 and nflog prefix
Date: Mon, 15 May 2006 11:10:24 +0200 [thread overview]
Message-ID: <44684580.7070504@trash.net> (raw)
In-Reply-To: <44684441.8060502@snapgear.com>
Philip Craig wrote:
> On 05/15/2006 05:06 PM, Patrick McHardy wrote:
>
>>Right, I somehow though the prefix was also configured using netlink,
>>which is of course wrong. In that case I think nfnetlink_log should
>>just 0-terminate the string. BTW, Is there any reason why the prefix
>>is truncated to NFULNL_PREFIXLEN?
>
>
> I just noticed that net/netfilter/nf_log.c limits the prefix to
> NF_LOG_PREFIXLEN=128. Don't know if this affects the decision.
Not really - if there is a second limit the minimum will be effective,
but that alone is no reason to truncate it.
#define NFULNL_PREFIXLEN 30 /* just like old log target */
I guess this tells us why the limit exists, but since nfnetlink_log
is not compatible with the old ULOG structure anyway, this could
just as well be done by the compat library.
prev parent reply other threads:[~2006-05-15 9:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-15 2:49 ulogd2 and nflog prefix Philip Craig
2006-05-15 5:36 ` Patrick McHardy
2006-05-15 6:59 ` Philip Craig
2006-05-15 7:06 ` Patrick McHardy
2006-05-15 7:33 ` Philip Craig
2006-05-15 7:39 ` Patrick McHardy
2006-05-15 7:59 ` Philip Craig
2006-05-15 8:31 ` Patrick McHardy
2006-05-15 9:35 ` Harald Welte
2006-05-15 9:41 ` Patrick McHardy
2006-05-15 9:05 ` Philip Craig
2006-05-15 9:10 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44684580.7070504@trash.net \
--to=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=philipc@snapgear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.