From: "Jan Beulich" <jbeulich@novell.com>
To: Pascal Bouchareine <pascal@gandi.net>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] blkfront: ioctls/geometry, 2.6
Date: Tue, 16 May 2006 09:18:39 +0200 [thread overview]
Message-ID: <446998EF.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20060515181525.GA2110@bar.gandi.net>
We did a similar patch recently here (not submitted, yet) - so I immediately see some concerns with your patch:
- Why do you need to add BLKGETSIZE and BLKGETSIZE64? block/ioctl.c is already taking care of those, they should never
arrive at the driver.
- The calculation of the cylinder value seems odd to me. Why don't you use sector_div() here?
- There is an apparently unused variable 'dpart' left in blkif_getgeo().
Jan
>>> Pascal Bouchareine <pascal@gandi.net> 15.05.06 20:15 >>>
Hi,
Adds HDIO_GETGEO, BLKGETSIZE, BLKGETSIZE64 support to blkfront.
An attempt to merge in the following sent previously by Ian Pratt :
http://lists.xensource.com/archives/html/xen-devel/2005-01/msg00659.html
Taking into account the block_device_operations for get_geom.
Regards,
Pascal
--
\o/ Pascal Bouchareine - Gandi
g 0170393757 15, place de la Nation - 75011 Paris
next prev parent reply other threads:[~2006-05-16 7:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-15 18:15 [PATCH] blkfront: ioctls/geometry, 2.6 Pascal Bouchareine
2006-05-16 7:18 ` Jan Beulich [this message]
2006-05-16 7:35 ` Pascal Bouchareine
2006-05-16 7:49 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446998EF.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=pascal@gandi.net \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.