From: Jeff Garzik <jeff@garzik.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [Fwd: [RFT] major libata update]
Date: Tue, 16 May 2006 12:39:13 -0400 [thread overview]
Message-ID: <446A0031.1080209@garzik.org> (raw)
In-Reply-To: <1147797042.3505.44.camel@mulgrave.il.steeleye.com>
James Bottomley wrote:
> On Tue, 2006-05-16 at 12:06 -0400, Jeff Garzik wrote:
>> Sigh. They clearly do not have the same effect, because the above code
>> guarantees that a timeout is forced, regardless of whether the timer has
>> fired or not. That in turn guarantees that the timeout callback
>> (->eh_timed_out) is called, and the cmd is in a very specific state.
>
> the API claims to be forcibly aborting a command, which is *not* a
> timeout ... trying to pretend to the midlayer that it is is the wrong
> processing model. You may choose to call this API because of a class
> internal timeout, but you don't need the callback notification that it
> is a timeout in this case, you already know it is.
I can certainly agree the name may not be the best choice. Naming based
on implementation, it could be scsi_force_timeout_cmd() or somesuch.
Jeff
next prev parent reply other threads:[~2006-05-16 16:39 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-15 17:08 [Fwd: [RFT] major libata update] Jeff Garzik
2006-05-16 14:18 ` James Bottomley
2006-05-16 15:41 ` Jeff Garzik
2006-05-16 15:51 ` James Bottomley
2006-05-16 16:06 ` Jeff Garzik
2006-05-16 16:30 ` James Bottomley
2006-05-16 16:39 ` Jeff Garzik [this message]
2006-05-16 21:55 ` Luben Tuikov
2006-05-16 21:32 ` Luben Tuikov
2006-05-16 16:08 ` Tejun Heo
2006-05-16 16:13 ` Tejun Heo
2006-05-16 16:29 ` James Bottomley
2006-05-16 16:37 ` Jeff Garzik
2006-05-16 16:39 ` Tejun Heo
2006-05-16 16:50 ` James Bottomley
2006-05-16 17:07 ` Tejun Heo
2006-05-16 17:09 ` Jeff Garzik
2006-05-16 19:58 ` Christoph Hellwig
2006-05-16 20:02 ` Jeff Garzik
2006-05-16 21:28 ` James Bottomley
2006-05-18 3:27 ` Tejun Heo
2006-05-19 12:07 ` [PATCH] SCSI: make scsi_implement_eh() generic API for SCSI transports Tejun Heo
2006-05-16 16:12 ` [Fwd: [RFT] major libata update] Jeff Garzik
2006-05-16 16:38 ` James Bottomley
2006-05-16 16:57 ` Jeff Garzik
2006-05-17 7:37 ` Jens Axboe
2006-05-17 15:06 ` Jeff Garzik
2006-05-17 15:50 ` James Bottomley
2006-05-17 15:58 ` James Smart
2006-05-17 16:17 ` Jeff Garzik
2006-05-17 17:53 ` James Bottomley
2006-05-17 22:08 ` Jeff Garzik
2006-05-17 22:15 ` Jeff Garzik
2006-05-17 17:47 ` Linus Torvalds
2006-05-17 17:55 ` Jens Axboe
2006-05-17 22:04 ` Linus Torvalds
2006-05-17 22:12 ` Jeff Garzik
2006-05-17 21:41 ` Jeff Garzik
2006-05-17 21:52 ` Douglas Gilbert
2006-05-17 22:20 ` Linus Torvalds
2006-05-18 3:04 ` Luben Tuikov
2006-05-17 16:05 ` Douglas Gilbert
2006-05-17 17:37 ` Jens Axboe
2006-05-17 21:58 ` Jeff Garzik
2006-05-18 7:21 ` Jens Axboe
2006-05-16 18:28 ` Luben Tuikov
2006-05-16 18:15 ` Luben Tuikov
2006-05-16 18:05 ` Luben Tuikov
2006-05-16 18:38 ` James Bottomley
2006-05-16 22:24 ` Luben Tuikov
2006-05-16 22:29 ` James Bottomley
2006-05-16 23:02 ` Luben Tuikov
2006-05-16 23:12 ` James Bottomley
2006-05-17 0:25 ` Luben Tuikov
2006-05-17 14:09 ` James Bottomley
2006-05-18 2:39 ` Luben Tuikov
2006-05-18 13:57 ` James Bottomley
2006-05-19 3:28 ` Luben Tuikov
2006-05-17 14:02 ` missed patch: Block I/O while SG reset operation in progress James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446A0031.1080209@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.