From: "Jan Beulich" <jbeulich@novell.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Andrew Morton" <akpm@osdl.org>, "Andreas Kleen" <ak@suse.de>,
<linux-kernel@vger.kernel.org>, <discuss@x86-64.org>
Subject: Re: [PATCH 1/3] reliable stack trace support
Date: Tue, 16 May 2006 17:22:31 +0200 [thread overview]
Message-ID: <446A0A57.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20060516143937.GA10760@elte.hu>
>>> Ingo Molnar <mingo@elte.hu> 16.05.06 16:39 >>>
>> +config STACK_UNWIND
>> + bool "Stack unwind support"
>> + depends on UNWIND_INFO
>> + depends on n
>
>'depends on n' ? Also, i think this should be 'default y'. The code is
Subsequent patches then change it to X86_64 and then X86. This is just so the patch can be used standalone.
>very clean. Curious: how much testing has it seen?
The code, in slightly different shape, has been in use in NLKD (and its non-Linux ancestor) for several years. The only
new code is the hook-up for the stack trace display functions, where I tried to make sure I test all (known to me)
possibilities.
Jan
next prev parent reply other threads:[~2006-05-16 15:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 14:21 [PATCH 1/3] reliable stack trace support Jan Beulich
2006-05-16 14:39 ` Ingo Molnar
2006-05-16 15:22 ` Jan Beulich [this message]
2006-05-16 15:25 ` Ingo Molnar
2006-05-16 15:04 ` Andi Kleen
2006-05-18 13:42 ` Jan Beulich
2006-05-18 15:32 ` [discuss] " Andi Kleen
2006-05-16 15:05 ` Ingo Molnar
2006-05-16 16:01 ` Jan Beulich
2006-05-18 11:16 ` Pavel Machek
2006-05-18 12:04 ` Jan Beulich
2006-05-18 12:14 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446A0A57.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.