* [KJ] [PATCH] ip2main.c : replace pci_find_device by pci_get_device
@ 2006-05-16 20:55 trem
2006-05-17 0:09 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: trem @ 2006-05-16 20:55 UTC (permalink / raw)
To: kernel-janitors
From: trem <tremyfr at yahoo.fr <https://lists.osdl.org/mailman/listinfo/kernel-janitors>>
This patch simply change pci_find_device by pci_get_device, because
pci_find_device is deprecated.
Signed-Off-By: trem <tremyfr at yahoo.fr <https://lists.osdl.org/mailman/listinfo/kernel-janitors>>
---
diff --git a/drivers/char/ip2/ip2main.c b/drivers/char/ip2/ip2main.c
index 03db1cb..c4311b7 100644
--- a/drivers/char/ip2/ip2main.c
+++ b/drivers/char/ip2/ip2main.c
@@ -594,7 +594,7 @@ ip2_loadmain(int *iop, int *irqp, unsign
#ifdef CONFIG_PCI
{
struct pci_dev *pci_dev_i = NULL;
- pci_dev_i = pci_find_device(PCI_VENDOR_ID_COMPUTONE,
+ pci_dev_i = pci_get_device(PCI_VENDOR_ID_COMPUTONE,
PCI_DEVICE_ID_COMPUTONE_IP2EX, pci_dev_i);
if (pci_dev_i != NULL) {
unsigned int addr;
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [KJ] [PATCH] ip2main.c : replace pci_find_device by pci_get_device
2006-05-16 20:55 [KJ] [PATCH] ip2main.c : replace pci_find_device by pci_get_device trem
@ 2006-05-17 0:09 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2006-05-17 0:09 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
On Tue, May 16, 2006 at 10:55:23PM +0200, trem wrote:
> From: trem <tremyfr at yahoo.fr <https://lists.osdl.org/mailman/listinfo/kernel-janitors>>
>
> This patch simply change pci_find_device by pci_get_device, because
> pci_find_device is deprecated.
But what about the reference count leak you just caused? These are not
simple changes.
> Signed-Off-By: trem <tremyfr at yahoo.fr <https://lists.osdl.org/mailman/listinfo/kernel-janitors>>
Put full email address in here please, and no web page.
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-17 0:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-16 20:55 [KJ] [PATCH] ip2main.c : replace pci_find_device by pci_get_device trem
2006-05-17 0:09 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.