* [NETFILTER 2/3]: H.323 helper: fix sequence extension parsing
@ 2006-05-23 9:41 Patrick McHardy
0 siblings, 0 replies; only message in thread
From: Patrick McHardy @ 2006-05-23 9:41 UTC (permalink / raw)
To: David S. Miller; +Cc: Netfilter Development Mailinglist
[-- Attachment #1: 02.diff --]
[-- Type: text/plain, Size: 1244 bytes --]
[NETFILTER]: H.323 helper: fix sequence extension parsing
When parsing unknown sequence extensions the "son"-pointer points behind
the last known extension for this type, don't try to interpret it.
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit e79f105111e9a6088868a879934d0574ce6230ad
tree 5d61518ccb84bd58632eca399235459d9a2cd49c
parent 97326cd6bc2a1360c213113cf1c7bc5514ad6d5b
author Patrick McHardy <kaber@trash.net> Tue, 23 May 2006 11:16:22 +0200
committer Patrick McHardy <kaber@trash.net> Tue, 23 May 2006 11:16:22 +0200
net/ipv4/netfilter/ip_conntrack_helper_h323_asn1.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/netfilter/ip_conntrack_helper_h323_asn1.c b/net/ipv4/netfilter/ip_conntrack_helper_h323_asn1.c
index 5d04438..26dfeca 100644
--- a/net/ipv4/netfilter/ip_conntrack_helper_h323_asn1.c
+++ b/net/ipv4/netfilter/ip_conntrack_helper_h323_asn1.c
@@ -555,7 +555,7 @@ int decode_seq(bitstr_t * bs, field_t *
/* Decode the extension components */
for (opt = 0; opt < bmp2_len; opt++, i++, son++) {
- if (son->attr & STOP) {
+ if (i < f->ub && son->attr & STOP) {
PRINT("%*.s%s\n", (level + 1) * TAB_SIZE, " ",
son->name);
return H323_ERROR_STOP;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-05-23 9:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-23 9:41 [NETFILTER 2/3]: H.323 helper: fix sequence extension parsing Patrick McHardy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.