[RFC][PATCH] Allow privcmd to support the _compat hypercalls

[RFC][PATCH] Allow privcmd to support the _compat hypercalls

[Anthony Liguori]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi Keir,

I was encountering an odd error where Xend was tossing an EINVAL on 
xc_evtchn_alloc_unbound.  After tracking it down, it turns out that this 
was because of an older userspace that was using the _compat version of 
the hypercalls.

Since the hypervisor still supports these calls, is there a compelling 
reason to not allow privcmd to expose these calls?  If not, please apply 
the following patch.

Regards,

Anthony Liguori

[-- Attachment #2: 10152-privcmd-compat.diff --]
[-- Type: text/plain, Size: 1115 bytes --]

# HG changeset patch
# User Anthony Liguori <anthony@codemonkey.ws>
# Node ID daa038c99299f3770f6724b7e23f44451b36da3e
# Parent  ad33b3882867f6ab4466383129aa3827c64508d3
Allow compat hypercalls to be made (to support older userspaces).

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

diff -r ad33b3882867 -r daa038c99299 linux-2.6-xen-sparse/drivers/xen/privcmd/privcmd.c
--- a/linux-2.6-xen-sparse/drivers/xen/privcmd/privcmd.c	Wed May 24 19:41:47 2006 +0100
+++ b/linux-2.6-xen-sparse/drivers/xen/privcmd/privcmd.c	Thu May 25 12:48:32 2006 -0500
@@ -267,6 +267,9 @@ static int __init privcmd_init(void)
 	set_bit(__HYPERVISOR_mmuext_op,        hypercall_permission_map);
 	set_bit(__HYPERVISOR_xen_version,      hypercall_permission_map);
 	set_bit(__HYPERVISOR_sched_op,         hypercall_permission_map);
+	set_bit(__HYPERVISOR_sched_op_compat,  hypercall_permission_map);
+	set_bit(__HYPERVISOR_event_channel_op_compat, hypercall_permission_map);
+	set_bit(__HYPERVISOR_physdev_op_compat, hypercall_permission_map);
 
 	privcmd_intf = create_xen_proc_entry("privcmd", 0400);
 	if (privcmd_intf != NULL)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel