[KJ] [PATCH] drivers/char/rocket.c : replace pci_find_device by

[KJ] [PATCH] drivers/char/rocket.c : replace pci_find_device by

[trem]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

From: trem <tremyfr@yahoo.fr>

This patch simply change pci_find_device by pci_get_device, because
pci_find_device is deprecated. No pci_dev_put is needed because the
loop isn't broken, and pci_get_device decrement the counter of the
device given as from parameter.

Signed-Off-By: trem <tremyfr@yahoo.fr>
---

[-- Attachment #2: rocket_replace_pci_find_device_by_pci_get_device.patch --]
[-- Type: text/x-patch, Size: 493 bytes --]

diff --git a/drivers/char/rocket.c b/drivers/char/rocket.c
index 7edc6a4..2682c8c 100644
--- a/drivers/char/rocket.c
+++ b/drivers/char/rocket.c
@@ -2230,7 +2230,7 @@ static int __init init_PCI(int boards_fo
 	int count = 0;
 
 	/*  Work through the PCI device list, pulling out ours */
-	while ((dev = pci_find_device(PCI_VENDOR_ID_RP, PCI_ANY_ID, dev))) {
+	while ((dev = pci_get_device(PCI_VENDOR_ID_RP, PCI_ANY_ID, dev))) {
 		if (register_PCI(count + boards_found, dev))
 			count++;
 	}

[-- Attachment #3: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] drivers/char/rocket.c : replace pci_find_device by

[Greg KH]

On Sat, May 27, 2006 at 11:24:52PM +0200, trem wrote:
> From: trem <tremyfr@yahoo.fr>
> 
> This patch simply change pci_find_device by pci_get_device, because
> pci_find_device is deprecated. No pci_dev_put is needed because the
> loop isn't broken, and pci_get_device decrement the counter of the
> device given as from parameter.
> 
> Signed-Off-By: trem <tremyfr@yahoo.fr>

No, this driver should be switched to the proper pci_register_driver()
api instead.

thanks,

greg k-h
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors