Re: nf_conntrack_proto_sctp.c:(.text+0x2e660): undefined reference to `local_bh_disable'

Re: nf_conntrack_proto_sctp.c:(.text+0x2e660): undefined reference to `local_bh_disable'

[Yasuyuki KOZAKAI]

From: Toralf Förster <toralf.foerster@gmx.de>
Date: Wed, 31 May 2006 12:53:51 +0200

> Compiling current kernel linux-2.6.17-rc5-git7 I got this error:
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> net/built-in.o: In function `sctp_print_conntrack':
> nf_conntrack_proto_sctp.c:(.text+0x2e660): undefined reference to `local_bh_disable'
> net/built-in.o: In function `sctp_packet':
> nf_conntrack_proto_sctp.c:(.text+0x2e8c1): undefined reference to `local_bh_disable'
> net/built-in.o: In function `ctnetlink_dump_table':
> nf_conntrack_netlink.c:(.text+0x2f710): undefined reference to `local_bh_disable'
> net/built-in.o: In function `ctnetlink_dump_table_w':
> nf_conntrack_netlink.c:(.text+0x2f840): undefined reference to `local_bh_disable'
> net/built-in.o: In function `ctnetlink_new_conntrack':
> nf_conntrack_netlink.c:(.text+0x307c9): undefined reference to `local_bh_disable'
> net/built-in.o:nf_conntrack_netlink.c:(.text+0x311cc): more undefined references to `local_bh_disable' follow
> make: *** [.tmp_vmlinux1] Error 1
> 
> .config is attached.

Actually nf_conntrack_proto_sctp.c doesn't include spinlock.h.

But to compile them, I also needed to add interrupt.h to them.
I wonder why that is necessary. they don't call local_bh_{disable,enable}
directly but call {read, write}_lock_bh(). Then I think that spinlock.h is
enough and spinlock_api_up.h should include interrupt.h.

Anyway, I attach a patch make them include spinlock.h and interrupt.h
like ip_conntrack_netlink.c.

-- Yasuyuki Kozakai

Re: nf_conntrack_proto_sctp.c:(.text+0x2e660): undefined reference to `local_bh_disable'

[Yasuyuki KOZAKAI]

[-- Attachment #1: Type: Text/Plain, Size: 253 bytes --]

From: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
Date: Thu, 01 Jun 2006 12:01:27 +0900 (JST)

> Anyway, I attach a patch make them include spinlock.h and interrupt.h
> like ip_conntrack_netlink.c.

Sorry, I attach this time.

-- Yasuyuki Kozakai

[-- Attachment #2: undef-lock_bh.patch --]
[-- Type: Text/Plain, Size: 2220 bytes --]

[NETFILTER] nf_conntrack: Fix undefined references to local_bh_*

  CC      net/netfilter/nf_conntrack_proto_sctp.o
net/netfilter/nf_conntrack_proto_sctp.c: In function `sctp_print_conntrack':
net/netfilter/nf_conntrack_proto_sctp.c:206: warning: implicit declaration of function `local_bh_disable'
net/netfilter/nf_conntrack_proto_sctp.c:208: warning: implicit declaration of function `local_bh_enable'
  CC      net/netfilter/nf_conntrack_netlink.o
net/netfilter/nf_conntrack_netlink.c: In function `ctnetlink_dump_table':
net/netfilter/nf_conntrack_netlink.c:429: warning: implicit declaration of function `local_bh_disable'
net/netfilter/nf_conntrack_netlink.c:452: warning: implicit declaration of function `local_bh_enable'

Spotted by Toralf Förster

Signed-off-by: Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp>

---
commit 867779436005b3b16466146ddd226e2faabee488
tree 6e2d3efc5bab4b2eddf5144d4973de8413c2ad23
parent ba8f5baba79da8eb502f8534c3a8ecb64aceb790
author Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp> Thu, 01 Jun 2006 11:21:52 +0900
committer Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp> Thu, 01 Jun 2006 11:21:52 +0900

 net/netfilter/nf_conntrack_netlink.c    |    1 +
 net/netfilter/nf_conntrack_proto_sctp.c |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index bd10eb9..bb9f781 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -29,6 +29,7 @@
 #include <linux/errno.h>
 #include <linux/netlink.h>
 #include <linux/spinlock.h>
+#include <linux/interrupt.h>
 #include <linux/notifier.h>
 
 #include <linux/netfilter.h>
diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c
index 0c6da49..0839b70 100644
--- a/net/netfilter/nf_conntrack_proto_sctp.c
+++ b/net/netfilter/nf_conntrack_proto_sctp.c
@@ -28,6 +28,8 @@
 #include <linux/sctp.h>
 #include <linux/string.h>
 #include <linux/seq_file.h>
+#include <linux/spinlock.h>
+#include <linux/interrupt.h>
 
 #include <net/netfilter/nf_conntrack.h>
 #include <net/netfilter/nf_conntrack_protocol.h>

Re: nf_conntrack_proto_sctp.c:(.text+0x2e660): undefined reference to `local_bh_disable'

[Patrick McHardy]

Yasuyuki KOZAKAI wrote:
> [NETFILTER] nf_conntrack: Fix undefined references to local_bh_*

Applied, thanks Yasuyuki.