All of lore.kernel.org
 help / color / mirror / Atom feed
* Error checking on migration?
@ 2006-06-06  1:52 John Byrne
  2006-06-06  2:50 ` Anthony Liguori
  0 siblings, 1 reply; 3+ messages in thread
From: John Byrne @ 2006-06-06  1:52 UTC (permalink / raw)
  To: xen-devel


I've noticed that migration doesn't fail if the VM cannot access the 
disk image on the new host. (xen-unstable 10273)  The VM ends up on the 
new host and hangs when it does a disk access. This is a somewhat evil 
behavior.

Does anyone have a fix for this in-hand, somewhere? If not, any advice 
where to look to fix the problem?

Thanks,

John Byrne

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Error checking on migration?
  2006-06-06  1:52 Error checking on migration? John Byrne
@ 2006-06-06  2:50 ` Anthony Liguori
  2006-06-06 11:02   ` Ewan Mellor
  0 siblings, 1 reply; 3+ messages in thread
From: Anthony Liguori @ 2006-06-06  2:50 UTC (permalink / raw)
  To: John Byrne; +Cc: xen-devel

John Byrne wrote:
>
> I've noticed that migration doesn't fail if the VM cannot access the 
> disk image on the new host. (xen-unstable 10273)  The VM ends up on 
> the new host and hangs when it does a disk access. This is a somewhat 
> evil behavior.

You could add some basic sanity checking in XendRestore.py:restore() 
before xd.restore_() is invoked.  A consequence of doing device setup 
through scripts is that the only proper way to know if a device creation 
will succeed is by actually creating it.  It's further complicated by 
the race condition that results by doing the checking before actually 
grabbing the devices (what if another migration is in progress that 
happens to use the same devices).

At any rate, having some sort of error checking is probably better than 
having none at all.

Regards,

Anthony Liguori

>
> Does anyone have a fix for this in-hand, somewhere? If not, any advice 
> where to look to fix the problem?
>
> Thanks,
>
> John Byrne
>
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Error checking on migration?
  2006-06-06  2:50 ` Anthony Liguori
@ 2006-06-06 11:02   ` Ewan Mellor
  0 siblings, 0 replies; 3+ messages in thread
From: Ewan Mellor @ 2006-06-06 11:02 UTC (permalink / raw)
  To: Anthony Liguori; +Cc: xen-devel, John Byrne

On Mon, Jun 05, 2006 at 09:50:06PM -0500, Anthony Liguori wrote:

> John Byrne wrote:
> >
> >I've noticed that migration doesn't fail if the VM cannot access the 
> >disk image on the new host. (xen-unstable 10273)  The VM ends up on 
> >the new host and hangs when it does a disk access. This is a somewhat 
> >evil behavior.
> 
> You could add some basic sanity checking in XendRestore.py:restore() 
> before xd.restore_() is invoked.  A consequence of doing device setup 
> through scripts is that the only proper way to know if a device creation 
> will succeed is by actually creating it.  It's further complicated by 
> the race condition that results by doing the checking before actually 
> grabbing the devices (what if another migration is in progress that 
> happens to use the same devices).

Also, migration to localhost is very useful for testing, so it's also 
complicated by the fact that the outgoing domain is using the devices
when the process starts, so you have to be careful to do the checks with
that in mind.

Ewan.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-06-06 11:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-06  1:52 Error checking on migration? John Byrne
2006-06-06  2:50 ` Anthony Liguori
2006-06-06 11:02   ` Ewan Mellor

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.