Re: [Bluez-devel] [PATCH] SCO flow control

[Fabien Chevalier <fabchevalier@free.fr>]

Hi Marcel,

>>> Another question is if we really should queue the data in sk_write_queue
>>> and not directly in the core. I would prefer to send the data to the
>>> core and then stream it from there.
>> That's an interesting question... :-)
>> I asked it myself when i started to design this feature.
>> In fact having outgoing packets stored in a socket queue has some 
>> advantages:
>>    * it makes use of the BSD socket send queue, and thus can reuse some 
>> generic socket queue management related functions, which rely on some 
>> well known sk_buff variable (sk_sndbuff, sk_wmem_alloc, sk_rcvbuff, 
>> sk_rmem_alloc ...)
>>    * it makes the thing symetrical, both uplink and downlink path make 
>> use socket queues to buffer data.
>>
>> As such I thought there were not any valid reason to put in the core... 
>> however if you have suggestions i would be very happy to hear them. :-)
> 
> Actually I never thought about SCO as socket is the best interface. So
> we might wanna move away from it sometime in the future. And in this
> case it would be great if it uses simple SKB queues or maybe kfifo for
> it. Even if this sounds like more work right now, I might be worth it.

It might make sense: however we must take into account the following 
constraints:
   - we must be aple to setup fifo lengths from userspace, so that to 
simulate a variable size ring buffer as found on sound card hardware.
   - we must be able to put the sending task to sleep, and wake it up 
later, when the fifo gets 'full'.

I'm not against this, even if it means more work...
However i don't have any precise idea on which communication mechanism 
to use between userspace/kernelspace. Any ideas ??

> 
> Let's have another patch on top of 2.6.16-mh1 and maybe you also wanna
> adapt scotest for testing it.
> 
Ok, i'm gonna work on that then...

Cheers,

Fabien


_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel