All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anne Thrax <foobarfoobarfoobar@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH 2.6.16.20 001/001l] netfilter: frees skb
Date: Thu, 15 Jun 2006 19:54:47 +0000	[thread overview]
Message-ID: <4491BB07.8000501@gmail.com> (raw)
In-Reply-To: <20060615121356.43791.qmail@web8714.mail.in.yahoo.com>

> This removes the use of kfree in freeing skbs. 
> kfree has been replaced with kfree_skb.
> 
> Signed-off-by: <nilayvaish@yahoo.com>
> ---
> --- a/net/ipv4/netfilter/ipt_recent.c   2006-03-20 11:23:29.000000000 +0530
> +++ b/net/ipv4/netfilter/ipt_recent.c   2006-06-15 10:52:59.000000000 +0530
> @@ -322,7 +322,7 @@ static int ip_recent_ctrl(struct file *f
> 
>  kfree(skb->nh.iph);
>  out_free_skb:
> - kfree(skb);
> + kfree_skb(skb);
>  out_free_info:
>  kfree(info);

I think that I've already sent in a patch for this. If so, then you need to
not only switch the kfree() with kfree_skb(). The skb being freed was
allocated with kmalloc(), so you need to switch that with alloc_skb().
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2006-06-15 19:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-15 12:13 [KJ] [PATCH 2.6.16.20 001/001l] netfilter: frees skb using nilay vaish
2006-06-15 14:37 ` Randy.Dunlap
2006-06-15 19:54 ` Anne Thrax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4491BB07.8000501@gmail.com \
    --to=foobarfoobarfoobar@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.