[KJ] [PATCH 2.6.16.20 001/001l] netfilter: frees skb using

[KJ] [PATCH 2.6.16.20 001/001l] netfilter: frees skb using

[nilay vaish]

[-- Attachment #1.1: Type: text/plain, Size: 863 bytes --]


From: Nilay Vaish <nilayvaish@yahoo.com>

This removes the use of kfree in freeing skbs. 
kfree has been replaced with kfree_skb.

Signed-off-by: <nilayvaish@yahoo.com>
---
--- a/net/ipv4/netfilter/ipt_recent.c   2006-03-20 11:23:29.000000000 +0530
+++ b/net/ipv4/netfilter/ipt_recent.c   2006-06-15 10:52:59.000000000 +0530
@@ -322,7 +322,7 @@ static int ip_recent_ctrl(struct file *f

 kfree(skb->nh.iph);
 out_free_skb:
- kfree(skb);
+ kfree_skb(skb);
 out_free_info:
 kfree(info);




 Send instant messages to your online friends http://in.messenger.yahoo.com 

 Stay connected with your friends even when away from PC.  Link: http://in.mobile.yahoo.com/new/messenger/  
 Send instant messages to your online friends http://in.messenger.yahoo.com 

 Stay connected with your friends even when away from PC.  Link: http://in.mobile.yahoo.com/new/messenger/  

[-- Attachment #1.2: Type: text/html, Size: 964 bytes --]

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 2.6.16.20 001/001l] netfilter: frees skb using

[Randy.Dunlap]

On Thu, 15 Jun 2006 13:13:56 +0100 (BST) nilay vaish wrote:

> 
> From: Nilay Vaish <nilayvaish@yahoo.com>
> 
> This removes the use of kfree in freeing skbs. 
> kfree has been replaced with kfree_skb.
> 
> Signed-off-by: <nilayvaish@yahoo.com>
> ---
> --- a/net/ipv4/netfilter/ipt_recent.c   2006-03-20 11:23:29.000000000 +0530
> +++ b/net/ipv4/netfilter/ipt_recent.c   2006-06-15 10:52:59.000000000 +0530
> @@ -322,7 +322,7 @@ static int ip_recent_ctrl(struct file *f
> 
>  kfree(skb->nh.iph);
>  out_free_skb:
> - kfree(skb);
> + kfree_skb(skb);
>  out_free_info:
>  kfree(info);

That should have some tabs at the start of each line.
Looks like your mail client or service stripped them out.
Please find and use one that preserves whitespace (tabs/spaces).

---
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 2.6.16.20 001/001l] netfilter: frees skb

[Anne Thrax]

> This removes the use of kfree in freeing skbs. 
> kfree has been replaced with kfree_skb.
> 
> Signed-off-by: <nilayvaish@yahoo.com>
> ---
> --- a/net/ipv4/netfilter/ipt_recent.c   2006-03-20 11:23:29.000000000 +0530
> +++ b/net/ipv4/netfilter/ipt_recent.c   2006-06-15 10:52:59.000000000 +0530
> @@ -322,7 +322,7 @@ static int ip_recent_ctrl(struct file *f
> 
>  kfree(skb->nh.iph);
>  out_free_skb:
> - kfree(skb);
> + kfree_skb(skb);
>  out_free_info:
>  kfree(info);

I think that I've already sent in a patch for this. If so, then you need to
not only switch the kfree() with kfree_skb(). The skb being freed was
allocated with kmalloc(), so you need to switch that with alloc_skb().
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors