From: Sinan Kaya <okaya@codeaurora.org>
To: Laura Abbott <labbott@redhat.com>,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com,
Kees Cook <keescook@chromium.org>
Subject: dmaengine: dmatest: Remove use of VLAs
Date: Mon, 9 Apr 2018 18:48:14 -0400 [thread overview]
Message-ID: <4491bde2-cf38-5103-0634-1986ecd32a7c@codeaurora.org> (raw)
On 4/9/2018 5:06 PM, Laura Abbott wrote:
> + /* dst_cnt can't be more than u8 */
> + dma_addr_t dma_pq[255];
This is 2k stack space on 64 bit architectures. Isn't that a lot?
WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@codeaurora.org>
To: Laura Abbott <labbott@redhat.com>,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] dmaengine: dmatest: Remove use of VLAs
Date: Mon, 9 Apr 2018 18:48:14 -0400 [thread overview]
Message-ID: <4491bde2-cf38-5103-0634-1986ecd32a7c@codeaurora.org> (raw)
In-Reply-To: <20180409210603.3575-1-labbott@redhat.com>
On 4/9/2018 5:06 PM, Laura Abbott wrote:
> + /* dst_cnt can't be more than u8 */
> + dma_addr_t dma_pq[255];
This is 2k stack space on 64 bit architectures. Isn't that a lot?
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next reply other threads:[~2018-04-09 22:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 22:48 Sinan Kaya [this message]
2018-04-09 22:48 ` [PATCH] dmaengine: dmatest: Remove use of VLAs Sinan Kaya
-- strict thread matches above, loose matches on Subject: below --
2018-04-10 15:38 Vinod Koul
2018-04-10 15:38 ` [PATCH] " Vinod Koul
2018-04-10 4:00 kbuild test robot
2018-04-10 4:00 ` [PATCH] " kbuild test robot
2018-04-10 4:00 ` kbuild test robot
2018-04-09 23:19 Sinan Kaya
2018-04-09 23:19 ` [PATCH] " okaya
2018-04-09 23:14 Laura Abbott
2018-04-09 23:14 ` [PATCH] " Laura Abbott
2018-04-09 21:06 Laura Abbott
2018-04-09 21:06 ` [PATCH] " Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4491bde2-cf38-5103-0634-1986ecd32a7c@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.