Re: [PATCH 1/2] arm64: dts: rockchip: enable NPU on rk3588-tiger

From: Heiko Stuebner <heiko@sntech.de>
To: Quentin Schulz <quentin.schulz@cherry.de>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Heiko Stuebner <heiko.stuebner@cherry.de>
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: enable NPU on rk3588-tiger
Date: Tue, 06 Jan 2026 19:52:56 +0100	[thread overview]
Message-ID: <4495583.CbtlEUcBR6@phil> (raw)
In-Reply-To: <de401340-be1c-4354-b6c8-c86d6f724c73@cherry.de>

Am Freitag, 28. November 2025, 11:32:17 Mitteleuropäische Normalzeit schrieb Quentin Schulz:
> Hi Heiko,
> 
> On 8/12/25 10:52 AM, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@cherry.de>
> > 
> > Enable the NPU cores and their mmus and wire up the supply-regulator.
> > The regulator itself was already defined, but it does not need to be
> > always on - the npu can control it.
> > 
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> 
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
> Tested-by: Quentin Schulz <quentin.schulz@cherry.de>
> 
> I still have the same remark about regulator-boot-on but this isn't a 
> blocker per-se.
> 
> The Oops I alluded to in my answer to the Jaguar patch is triggered by 
> making DRM_ACCEL_ROCKET driver built-in instead of as a module. I'm not 
> sure how much I will debug this on my side, I'll prolly just report this 
> on the ML in a few hours.

Just for people stumbling over this, the cause is the pm-domains
being on on boot and the iommu after probing disabling the domain.

See discussion in
https://lore.kernel.org/linux-rockchip/20251216055247.13150-1-rmxpzlb@gmail.com/