* [PATCH] xt_tcpudp.c match unregistration bug
@ 2006-06-12 7:35 Yuri Gushin
2006-06-19 15:00 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Yuri Gushin @ 2006-06-12 7:35 UTC (permalink / raw)
To: coreteam, netfilter-devel
Hi all,
There is a match unregistration bug in the __init function of xt_tcpudp.c;
"xt_unregister_match(AF_INET, &tcp_matchstruct)" is called twice,
leaving "udp_matchstruct" registered, in case of a failure in the
registration of the udp6 structure.
Attached is a patch to resolve this issue.
Signed-off-by: Yuri Gushin <yuri@ecl-labs.org>
--- a/net/netfilter/xt_tcpudp.c 2006-05-31 03:31:44.000000000 +0300
+++ b/net/netfilter/xt_tcpudp.c 2006-06-11 17:41:20.000000000 +0300
@@ -314,7 +314,7 @@
return ret;
out_unreg_udp:
- xt_unregister_match(AF_INET, &tcp_matchstruct);
+ xt_unregister_match(AF_INET, &udp_matchstruct);
out_unreg_tcp6:
xt_unregister_match(AF_INET6, &tcp6_matchstruct);
out_unreg_tcp:
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xt_tcpudp.c match unregistration bug
2006-06-12 7:35 [PATCH] xt_tcpudp.c match unregistration bug Yuri Gushin
@ 2006-06-19 15:00 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2006-06-19 15:00 UTC (permalink / raw)
To: Yuri Gushin; +Cc: coreteam, netfilter-devel
Yuri Gushin wrote:
> Hi all,
>
> There is a match unregistration bug in the __init function of xt_tcpudp.c;
>
> "xt_unregister_match(AF_INET, &tcp_matchstruct)" is called twice,
> leaving "udp_matchstruct" registered, in case of a failure in the
> registration of the udp6 structure.
>
> Attached is a patch to resolve this issue.
Applied. thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-19 15:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-12 7:35 [PATCH] xt_tcpudp.c match unregistration bug Yuri Gushin
2006-06-19 15:00 ` Patrick McHardy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.